Skip to content

Add missing semi-colon in BESTEST validation models #1988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mwetter merged 2 commits into from
Mar 12, 2025
Merged

Add missing semi-colon in BESTEST validation models #1988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dad1a87
Added missing semi-colon
mwetter Mar 10, 2025
3a8e45b
Merge branch 'master' into issue1987_missingSemicolon
mwetter Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions IBPSA/ThermalZones/ISO13790/Validation/BESTEST/Cases6xx/Case680FF.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
within IBPSA.ThermalZones.ISO13790.Validation.BESTEST.Cases6xx;
model Case680FF
extends IBPSA.ThermalZones.ISO13790.Validation.BESTEST.Cases6xx.Case600FF(zonHVAC(
UWal=0.15, URoo=0.1))
UWal=0.15, URoo=0.1));

annotation (Icon(coordinateSystem(preserveAspectRatio=false)), Diagram(
coordinateSystem(preserveAspectRatio=false)));
annotation (
Expand All @@ -16,7 +17,12 @@ The room temperature is free floating.
</html>", revisions="<html>
<ul>
<li>
May 3, 2024, Alessandro Maccarini:<br/>
March 10, 2025, by Michael Wetter:<br/>
Added missing semi-colon.</br>
This is for
<a href=\"https://github.com/ibpsa/modelica-ibpsa/issues/1987\">IBPSA, #1987</a>.
</li>
<li>May 3, 2024, Alessandro Maccarini:<br/>
First implementation.
</li>
</ul>
Expand Down
9 changes: 8 additions & 1 deletion IBPSA/ThermalZones/ISO13790/Validation/BESTEST/Cases9xx/Case980.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
within IBPSA.ThermalZones.ISO13790.Validation.BESTEST.Cases9xx;
model Case980 "Case 900, but with increased exterior wall and roof insulation"
extends IBPSA.ThermalZones.ISO13790.Validation.BESTEST.Cases9xx.Case900(zonHVAC(
UWal=0.15, URoo=0.1))
UWal=0.15, URoo=0.1));

annotation (
__Dymola_Commands(file="modelica://IBPSA/Resources/Scripts/Dymola/ThermalZones/ISO13790/Validation/BESTEST/Cases9xx/Case980.mos"
"Simulate and plot"),
Expand All @@ -12,6 +13,12 @@ model Case980 "Case 900, but with increased exterior wall and roof insulation"
Documentation(revisions="<html>
<ul>
<li>
March 10, 2025, by Michael Wetter:<br/>
Added missing semi-colon.</br>
This is for
<a href=\"https://github.com/ibpsa/modelica-ibpsa/issues/1987\">IBPSA, #1987</a>.
</li>
<li>
May 3, 2024, by Alessandro Maccarini:<br/>
First implementation.
</li>
Expand Down