Issue2037 use two port sensor for flow reversal#2038
Merged
Conversation
mwetter
approved these changes
Aug 19, 2025
khinkelman
approved these changes
Aug 19, 2025
Collaborator
There was a problem hiding this comment.
@mwetter the changes all look sound to me and consistent with Buildings PR#4296. I ran the example simulation locally and verified correct performance. After CI tests pass, this looks ready to merge.
Contributor
|
@khinkelman : Thanks for the verification and quick feedback. I will merge it to the master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #2037.