Skip to content

Commit 8f42d5e

Browse files
committed
Merge branch 'master' into issue663_UpdatePythonDependancies
2 parents 6ef1341 + 355bc4f commit 8f42d5e

File tree

15 files changed

+988
-43
lines changed

15 files changed

+988
-43
lines changed

bacnet/create_ttl.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
baseurl = 'http://127.0.0.1:80'
1919

2020
# Instatiate test case
21-
test_case_name = 'singlezone_commercial_hydronic'
21+
test_case_name = 'multizone_office_simple_hydronic'
2222
testid = requests.post("{0}/testcases/{1}/select".format(baseurl, test_case_name)).json()["testid"]
2323

2424
# Write the file prefix

releasenotes.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,12 @@ Released on xx/xx/xxxx.
77
**The following changes are backwards compatible and do not significantly change benchmark results:**
88

99
- Update heat pump documentation to BESTEST Hydronic Heat Pump testcase. This is for [#704](https://github.com/ibpsa/project1-boptest/issues/704).
10-
- Remove scipy and matplotlib dependencies from worker container. scipy.integrate.trapz was substituted with numpy.trapezoid in ``kpis/kpi_calculator.py``,
11-
scipy.interp1d linear with numpy.interp, and scipy.inter1d zero with a custom zero hold interpolation in ``data/data_manager.py``.
12-
Update pyfmi from 2.12 to 2.14, update numpy from 1.26.4 to 2.2.1, and update pandas from 1.5.3 to 2.2.3.
13-
Update worker Python from 3.10 to 3.11, and miniconda version from py310_24.30-1-Linux-x86_64 to py311_24.7.1-0-Linux-x86_64.
10+
- Enable BACnet interface to work with test case ``multizone_hydronic_simple_hydronic`` by creating the ``bacnet.ttl``. This is for [#735](https://github.com/ibpsa/project1-boptest/issues/735).
11+
- Remove the ``scenario`` field from the test case ``config.json``. This is for [#719](https://github.com/ibpsa/project1-boptest/issues/719).
12+
- Remove scipy and matplotlib dependencies from ``worker`` container. Substitute ``scipy.integrate.trapz`` with ``numpy.trapezoid`` in ``kpis/kpi_calculator.py``, ``scipy.interp1d`` linear with ``numpy.interp``, and ``scipy.inter1d`` zero with a custom zero hold interpolation in ``data/data_manager.py``.
13+
Update ``pyfmi`` from 2.12 to 2.14, update ``numpy`` from 1.26.4 to 2.2.1, and update ``pandas`` from 1.5.3 to 2.2.3.
14+
Update ``worker`` Python from 3.10 to 3.11, and ``miniconda`` version from ``py310_24.30-1-Linux-x86_64`` to ``py311_24.7.1-0-Linux-x86_64``.
15+
Update unit tests such that ``test_kpis.py``, ``test_forecast.py``, and ``test_testcase.py`` are run in the ``worker`` container, instead of the ``jm`` container.
1416
This is for [#663](https://github.com/ibpsa/project1-boptest/issues/663).
1517

1618
**The following changes are not backwards-compatible and significantly change benchmark results:**

testcase.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,9 @@ def __init__(self, fmupath='models/wrapped.fmu'):
9090
# Initialize test case
9191
self.initialize(self.config_json['start_time'], self.config_json['warmup_period'])
9292
# Set default scenario
93-
self.set_scenario(self.config_json['scenario'])
93+
scenario_default = {'electricity_price':'constant',
94+
'time_period': None}
95+
self.set_scenario(scenario_default)
9496

9597
def __initilize_data(self):
9698
'''Initializes objects for simulation data storage.

testcases/bestest_air/models/config.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,5 @@
33
"area" : 48.0,
44
"start_time" : 0.0,
55
"warmup_period" : 0.0,
6-
"step" : 3600.0,
7-
"scenario" : {"electricity_price":"constant",
8-
"time_period":null}
6+
"step" : 3600.0
97
}

testcases/bestest_hydronic/models/config.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,5 @@
33
"area" : 48.0,
44
"start_time" : 0.0,
55
"warmup_period" : 0.0,
6-
"step" : 3600.0,
7-
"scenario" : {"electricity_price":"constant",
8-
"time_period":null}
6+
"step" : 3600.0
97
}

testcases/bestest_hydronic_heat_pump/models/config.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,5 @@
33
"area" : 192.0,
44
"start_time" : 0.0,
55
"warmup_period" : 0.0,
6-
"step" : 3600.0,
7-
"scenario" : {"electricity_price":"constant",
8-
"time_period":null}
6+
"step" : 3600.0
97
}

testcases/multizone_office_simple_air/models/config.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,5 @@
33
"area" : 1662.66,
44
"start_time" : 0.0,
55
"warmup_period" : 0.0,
6-
"step" : 3600.0,
7-
"scenario" : {"electricity_price":"constant",
8-
"time_period":null}
6+
"step" : 3600.0
97
}

0 commit comments

Comments
 (0)