Skip to content

Feat/sandbox optimization #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CunjieLee wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Feat/sandbox optimization #769

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6564aca
feat:沙箱执行js代码时增加缓存能力
CunjieLee Jun 3, 2025
9c3a343
Merge branch 'ice-lab:master' into feat/sandbox-optimization
CunjieLee Jun 5, 2025
1d26b2c
Apply suggestion from @Copilot
ClarkXia Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 68 additions & 0 deletions packages/sandbox/src/constant.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@

export const globalsInES2015 = window.Proxy
? [
'Array',
'ArrayBuffer',
'Boolean',
'constructor',
'DataView',
'Date',
'decodeURI',
'decodeURIComponent',
'encodeURI',
'encodeURIComponent',
'Error',
'escape',
'eval',
'EvalError',
'Float32Array',
'Float64Array',
'Function',
'hasOwnProperty',
'Infinity',
'Int16Array',
'Int32Array',
'Int8Array',
'isFinite',
'isNaN',
'isPrototypeOf',
'JSON',
'Map',
'Math',
'NaN',
'Number',
'Object',
'parseFloat',
'parseInt',
'Promise',
'propertyIsEnumerable',
'Proxy',
'RangeError',
'ReferenceError',
'Reflect',
'RegExp',
'Set',
'String',
'Symbol',
'SyntaxError',
'toLocaleString',
'toString',
'TypeError',
'Uint16Array',
'Uint32Array',
'Uint8Array',
'Uint8ClampedArray',
'undefined',
'unescape',
'URIError',
'valueOf',
'WeakMap',
'WeakSet',
].filter((p) => /* just keep the available properties in current window context */ p in window)
: [];
const overwrittenGlobals = ['window', 'self', 'hasOwnProperty']
export const cachedGlobals = Array.from(
new Set(
globalsInES2015.concat(overwrittenGlobals).concat('requestAnimationFrame')
),
);
6 changes: 5 additions & 1 deletion packages/sandbox/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { cachedGlobals } from './constant';
export interface SandboxProps {
multiMode?: boolean;
}
Expand Down Expand Up @@ -99,7 +100,7 @@ export default class Sandbox {
if (!originalWindow.hasOwnProperty(p)) {
// record value added in sandbox
propertyAdded[p] = value;
// eslint-disable-next-line no-prototype-builtins
// eslint-disable-next-line no-prototype-builtins
} else if (!originalValues.hasOwnProperty(p)) {
// if it is already been setted in original window, record it's original value
originalValues[p] = originalWindow[p];
Expand Down Expand Up @@ -191,6 +192,9 @@ export default class Sandbox {
this.createProxySandbox();
}
try {
// Concatenate scopedGlobalVariables into variable declarations to cache global variables, avoiding proxy traversal on every use.
const scopedGlobalVariableDefinition = cachedGlobals.length ? `const {${cachedGlobals.join(',')}}=sandbox;` : '';
script =scopedGlobalVariableDefinition +script
const execScript = `with (sandbox) {;${script}\n}`;
// eslint-disable-next-line no-new-func
const code = new Function('sandbox', execScript).bind(this.sandbox);
Expand Down