Skip to content

Conversation

gtsp233
Copy link

@gtsp233 gtsp233 commented Jan 22, 2024

Fix for Cross-Site Scripting (XSS) Vulnerability

Hi, I've found a Cross-Site Scripting (XSS) vulnerability in the package @icedesign/richtext-renderer.

Vulnerability Details:

  • Severity: High/Critical
  • Description: There's a risk of malicious script execution when the html in controlled by an advorsary.

Steps to Reproduce(POC):

import RichtextRenderer from "@icedesign/richtext-renderer"
import React from "react";
import ReactDOM from "react-dom/client";

const root = ReactDOM.createRoot(document.getElementById("root"));

function App() {
  return (
    <RichtextRenderer html="<img src='' onerror=alert(1)" />
  );
}
root.render(<App />);

Suggested Fix or Mitigation:
Sanitize the html before rendering it using dangerouslySetInnerHtml

I've already fixed and tested this issue, and have submitted a pull request with the necessary changes. Please review and merge my pull request to resolve this vulnerability. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant