Conversation
added 7 commits
March 7, 2026 21:23
Fixes: ``` icemon(253199)/qt.core.qobject.connect: unknown(0): QObject::disconnect: Unexpected nullptr parameter @ ?icemon?|?icemon?|?icemon?|?icemon?|?libQt6Core.so.6?|... ```
Changes: - Create Monitor & HostInfoManager in main() directly - MainWindow is just an observer of those - Setup Monitor directly in main (without pass-through methods) - Remove duplicated logic in HostInfoManager from Monitor - Remove unnecessary QString<->QByteArray conversions, make this more explicit Leads to much cleaner code
Also makes at least one implicit enum->bool conversion more explicit.
Used to allow setting --testmode in CLI options.
HenryMiller1
approved these changes
May 1, 2026
| FinishedJobs::iterator it = m_finishedJobs.begin(); | ||
| for (const FinishedJobs::iterator itEnd = m_finishedJobs.end(); it != itEnd; ++it) { | ||
| auto it = m_finishedJobs.begin(); | ||
| for (const auto itEnd = m_finishedJobs.end(); it != itEnd; ++it) { |
Contributor
There was a problem hiding this comment.
general practice it is to move the end() call out of the loop, and leave begin() in. Begin is called once either way, while end() is called on each iteration - which is only needed if end() is expected to change inside the loop (and this implies other iteration invalidation issues).
I'm including to suggest range based for here as well.
| if (hostInfo) { | ||
| QToolTip::showText(gp + QPoint(10, 10), hostInfo->toolTip(), this, itemRect); | ||
| } else { | ||
| } else if (const auto monitor = m_starView->monitor()) { |
Contributor
There was a problem hiding this comment.
I don't like assigning variables inside an if. It works and is probably right in this case, but people expect to see == not =.
|
|
||
| const int MAX_JOB_COUNT = 10; | ||
| const int MAX_HOST_COUNT = 40; | ||
| const int MAX_HOST_COUNT = 20; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.