Fix m_nonzero_bkg definition to avoid overflows. #231
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the proposed solution in issue 230.
As a side effect, it will also softer (but not eliminate) the anomalous high TS values for injections where there was no
events in the background and kde smoothing was used. The reason is that now the bkg energy pdf is effectively capped to
numpy.finfo(np.double).resolution
(=1e-15).This still gives much more margin than the cap_ratio option, which effectively imposes much more restrictive values.
This solution just extends the already solution for the actual zero values when no cap_ratio is present.
skyllh/skyllh/analyses/i3/publicdata_ps/pdfratio.py
Lines 230 to 237 in 6704ef9