Add option to make explain cycle through colors of the rainbow (+ fix layering)
#2913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the child widget has multiple layers (e.g. `Stack`), the layout explanation would be partially hidden by the layers of the child widget. Just put the layout explanation in its own layer to mitigate this.
watsaig
changed the title
explain cycle through colors of the rainbowexplain cycle through colors of the rainbow (+ fix layering)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small quality-of-life change to give users the option to use either a single color for
explain, or to have it cycle through colors. Colors change at each level of the hierarchy, so it's easier to see what elements are part of what other elements, and to tell the difference between overlapping elements.See the
layoutexample:I'm very unsure about what to name things and what to re-export where, but hopefully this is close to useable.
The change is non-breaking, since
explainnow takesInto<ExplainColor>which has a blanketimpl From<C: Into<Color>>(so we can just pass aColor, same as before).