chore: improve counter example - #3264
Conversation
hecrj
left a comment
There was a problem hiding this comment.
I don't think these changes are necessarily an improvement.
|
Why aren't they? Container is arguably the second most used widget after text, so I think it's suitable for the first example one looks at. When it comes to formatting can you elaborate? I mean the change clearly simplifies it |
|
Are you asking in good faith because you are genuinely curious? Or will you silently disagree when I provide an explanation? If it's the former, then what do you think my concerns could be? What could be the reasons I don't like Can you think of anything? |
|
In terms of container, I think you're trying to say that counter example should be as simple as possible. But I think the goal should be to introduce people to the library, which I think should involve one of the first elements they are going to use in their first app, which container will certainly. In terms of formatting I completely have no idea. Maybe that adding lines to non one liners is faster? |
|
You are looking at it in a very short-sighted way.
The
Shorter does not mean simpler. Relying on the fact that I've put quite some thought on this. I am even writing a book about it. |
|
Okay makes sense |
This pr: