Scroll combo_box options on keyboard navigation - #3422
Open
EmmanuelDodoo wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
I was able to fix the scroll so it only happens on the top/bottom edges of the menu Recording.2026-08-13.143549.mp4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
combo_boxwidget supports navigating its options using the arrow keys but doesn't scroll up/down when the options are out of the viewport. This PR fixes that.Before
https://github.com/user-attachments/assets/12e24c69-7966-4fb2-b6a0-975e24034f0b
After
https://github.com/user-attachments/assets/48ee6059-8cee-45be-8142-fa33cabfaf0b