Skip to content

Switch combo box matchers from ascii-alphanumeric splitting to unicode word splitting #3428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edwloef wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −4
Open

Switch combo box matchers from ascii-alphanumeric splitting to unicode word splitting #3428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions widget/src/combo_box.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ use crate::text_input;

use std::fmt::Display;
use std::sync::atomic::{self, AtomicU64};
use unicode_segmentation::UnicodeSegmentation;

/// A widget for searching and selecting a single value from a list of options.
///
Expand Down Expand Up @@ -806,7 +807,7 @@ where
{
let query: Vec<String> = query
.to_lowercase()
.split(|c: char| !c.is_ascii_alphanumeric())
.unicode_words()
.map(String::from)
.collect();

Expand Down Expand Up @@ -834,7 +835,9 @@ fn build_matcher<T>(option: T) -> String
where
T: Display,
{
let mut matcher = option.to_string();
matcher.retain(|c| c.is_ascii_alphanumeric());
matcher.to_lowercase()
option
.to_string()
.unicode_words()
.collect::<String>()
.to_lowercase()
}
Loading