Skip to content

Update tabs/tab_bar to iced 0.14#350

Merged
genusistimelord merged 2 commits into
iced-rs:mainfrom
mytdragon:update/tabs
Aug 7, 2025
Merged

Update tabs/tab_bar to iced 0.14#350
genusistimelord merged 2 commits into
iced-rs:mainfrom
mytdragon:update/tabs

Conversation

@mytdragon

Copy link
Copy Markdown
Contributor

No description provided.

@mytdragon

Copy link
Copy Markdown
Contributor Author

@Redhawk18 on my fork I didn't have the update with iced_fonts. On the tab_bar widgets, I'm not so sure with the

let (_content, font, _shaping) = cancel();
// ...
(self.font.unwrap_or(font), self.icon_size)

Around src/widget/tab_bar.rs:693. It works but might be incorrect so feel free to edit to the correct way if it's wrong :)

genusistimelord
genusistimelord previously approved these changes Aug 7, 2025

@genusistimelord genusistimelord left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much for your help.

@genusistimelord genusistimelord merged commit 122ad17 into iced-rs:main Aug 7, 2025
2 checks passed
@Redhawk18

Copy link
Copy Markdown
Collaborator

Why are you not using content or shaping?

@genusistimelord

Copy link
Copy Markdown
Collaborator

not sure he can since it can use different fonts and icons. so it might have to stay advanced or be expanded to Require they use your font macros to generate the needed stuff.

@mytdragon

Copy link
Copy Markdown
Contributor Author

The original widget needed a fallback font for the icon, before it was using REQUIRED_FONT but since it's removed, I needed to use something. From what I see, icon content is set at Tab level when the icon font is at TabBar level. Maybe it should just fallback to default font

@Redhawk18

Copy link
Copy Markdown
Collaborator

The original widget needed a fallback font for the icon, before it was using REQUIRED_FONT but since it's removed, I needed to use something. From what I see, icon content is set at Tab level when the icon font is at TabBar level. Maybe it should just fallback to default font

Oh you don't need that then, iced aw just owns that font now. You'll find it at the crates root now in lib.rs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants