Add wasmJs target [WIP]#724
Closed
luca992 wants to merge 1 commit into
Closed
Conversation
In wasmJs generated code have to handle: Calls to 'js(code)' should be a single expression inside a top-level function body or a property initializer in Kotlin/Wasm.
Merged
Member
|
continued in #822 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't quite working yet, but started adding support for
wasmJs. It will build, but generated code for wasmJs doesn't work becausewasmJsonly supports calling js code in top level functions:Also, requires an updated moko-graphics with wasmJs added
It could also probably be cleaned up to share more code with the js target.