-
Notifications
You must be signed in to change notification settings - Fork 116
Typecheck spatial module #605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mfisher87
wants to merge
25
commits into
development
Choose a base branch
from
typecheck-spatial
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+362
−119
Open
Changes from 3 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
86345a5
Typecheck spatial module
mfisher87 bfa9562
Fix doctest I broke
mfisher87 153c307
add datetime import to query.py for typechecking
JessicaS11 e0ef967
make types in abc order
JessicaS11 635e31c
add shapely.Polygon accepted input to docstring
JessicaS11 130160b
change to ExhaustiveTypeGuardException error type
JessicaS11 830f471
change to ExhaustiveTypeGuardException error type
JessicaS11 0ca4485
Reorder `Spatial` private properties in alpha order
trey-stafford b035695
Remove typing allowing list of coordinates as strings
trey-stafford 1c1c490
Support shapely.Polygon for `spatial.geodataframe` `spatial_extent`
trey-stafford cbc761c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 52037e9
`spatial.geodataframe` supports a list of tuples for `spatial_extent`
trey-stafford 7c64991
Test code branch indicated as a "dev goal" in comment
trey-stafford 2adc38d
Fixup test to indicate that we want to read a bbox from file
trey-stafford 9df3ec7
Add test for unlikely error case
trey-stafford 6f771d8
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 3f923a6
Add unit test for unlikely error in `fmt_for_EGI`
trey-stafford 27de548
Fixup typeerror message and add test covering check in geodataframe
trey-stafford 191181e
Add test for code branch that performes a dateline-crossing adjustment
trey-stafford 9aa54dc
import icepyx as ipx in test_spatial
trey-stafford 207be53
Merge branch 'development' into typecheck-spatial
JessicaS11 c89df21
Refactor `geodataframe` to more clearly show where a list of floats i…
trey-stafford b632617
Convert `spatial_extent` to `list[float]` for most functions
trey-stafford 7675584
Update unit tests: spatial extent must be floats - not ints
trey-stafford 7bd668c
Remove OBE TODO
trey-stafford File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.