Skip to content

Conversation

@sdebruyn
Copy link

Probably resolves #123

I would also like to see logs from the pyicloud library.

@AndreyNikiforov
Copy link
Collaborator

Were you able to solve any problem with extra logging yet (or working on something where it helps)?

What does pyicloud expose with default DEBUG level? Does that extra info (if any) improve user experience for everybody using default logging setting?

@sdebruyn
Copy link
Author

One of the things it tells you is if found a cookie or not, which might be useful. E.g. in the case I had in #1005

@AndreyNikiforov
Copy link
Collaborator

Does default DEBUG level changes experience for user who do not need extra logs?

@sdebruyn
Copy link
Author

Probably, but then again, should the default logger level really be DEBUG? Most application would put this on info/warn

@AndreyNikiforov
Copy link
Collaborator

Probably, but then again, should the default logger level really be DEBUG? Most application would put this on info/warn

I agree that default logging set to DEBUG feels off-balance. Should we change it then? Probably opening a can of worms now as most of output today is done through logs and there are certain expectations for it (e.g. what is output by default).

@AndreyNikiforov AndreyNikiforov self-requested a review November 27, 2024 16:14
Copy link
Collaborator

@AndreyNikiforov AndreyNikiforov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default log level is DEBUG. Simply turning logging for pyicloudpd_ipd will increase amount of output for all users, 99.99% of which do not need extra logging. This challenge needs to be solved before we can merge changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Log level options

2 participants