Skip to content

Conversation

@sdebruyn
Copy link

Fixes #898 #911

Before attacking the tests, let me know what you think of this approach.

Raising the exception will always exit the current code path in authentication.py

@AndreyNikiforov
Copy link
Collaborator

IIUC you are trying solve two problems: a) that smtp notification is terminating the app when webui is enabled b) smtp notification is not supported for mfa requests. The solution is to send smtp notification on password/mfa requests while still keeping icloudpd with webui working to enter those credentials. Is the scope for initial auth only or re-auth as well?

@AndreyNikiforov AndreyNikiforov self-requested a review November 27, 2024 15:10
@sdebruyn
Copy link
Author

As long as the authenticator is called, it will also trigger the callback again. And indeed, it keeps it from exiting after sending the email. I also needed this to work better for #1008

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

service exits after sending 2fa notification email on startup

2 participants