fix: add pagination support for album folder listing #1131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: add pagination support for album folder listing Some iCloud accounts have more albums than are returned in a single response. Previously, the `_fetch_folders` method only fetched the first page of albums, ignoring any `continuationMarker` provided by the Apple Photos API. This patch adds support for pagination, looping through all available pages and aggregating the results. This resolves issues where certain albums (e.g. "Harry Potter") were visible in the iCloud Web UI but missing from tools like `icloudpd --list-albums`. Tested manually by confirming previously missing albums now appear.
Collaborator
|
@asherawelan add test and update changelog pls |
AndreyNikiforov
requested changes
May 8, 2025
Collaborator
AndreyNikiforov
left a comment
AndreyNikiforov
left a comment
There was a problem hiding this comment.
add test and update changelog, pls
Add unit tests for PhotoLibrary._fetch_folders to cover album listing logic Add TestPhotoLibraryListAlbums with tests for _fetch_folders with and without continuation markers.
Author
|
Tests and change log entry added |
Author
|
@AndreyNikiforov Could you please re-review |
Collaborator
@asherawelan pls check why lint and tests are failing. You should be able to run these checks locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: add pagination support for album folder listing
Some iCloud accounts have more albums than are returned in a single response. Previously, the
_fetch_foldersmethod only fetched the first page of albums, ignoring anycontinuationMarkerprovided by the Apple Photos API.This patch adds support for pagination, looping through all available pages and aggregating the results. This resolves issues where certain albums (e.g. "Harry Potter") were visible in the iCloud Web UI but missing from tools like
icloudpd --list-albums.Tested manually by confirming previously missing albums now appear.