fix: make tzlc content check case insensitive #1239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update compile_tzlc.py to perform case insensitive comparison when checking if timezone/locale compatibility test outputs match expected content. This makes the compatibility tests more robust by handling variations in capitalization that may occur across different systems. Before: content not in expected_content (case sensitive) After: content.lower() not in [c.lower() for c in expected_content] (case insensitive) This prevents false negatives when version strings have different capitalization (e.g., "Version:1.32.0" vs "version:1.32.0"). 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
AndreyNikiforov
force-pushed
the
fix/tzlc-case-insensitive-content-check
branch
from
27d7151 to
1c75058
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update compile_tzlc.py to perform case insensitive comparison when checking if timezone/locale compatibility test outputs match expected content. This makes the compatibility tests more robust by handling variations in capitalization that may occur across different systems.
Before: content not in expected_content (case sensitive)
After: content.lower() not in [c.lower() for c in expected_content] (case insensitive)
This prevents false negatives when version strings have different capitalization (e.g., "Version:1.32.0" vs "version:1.32.0").
🤖 Generated with Claude Code