Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/icloudpd/authentication.py
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,16 @@ def request_2sa(icloud: PyiCloudService, logger: logging.Logger) -> None:
def request_2fa(icloud: PyiCloudService, logger: logging.Logger) -> None:
"""Request two-factor authentication."""
devices = icloud.get_trusted_phone_numbers()

# Trigger push notification to trusted devices before prompting for code.
# Apple's auth flow (2026+) requires a PUT to /verify/trusteddevice/securitycode
# to initiate code delivery. Failure is non-fatal — the user can still enter
# a code if it arrives via another path.
if not icloud.trigger_push_notification():
logger.debug("Failed to trigger 2FA push notification, continuing anyway")
else:
logger.debug("2FA push notification triggered")

devices_count = len(devices)
device_index_alphabet = "abcdefghijklmnopqrstuvwxyz"
if devices_count > 0:
Expand Down
29 changes: 29 additions & 0 deletions src/pyicloud_ipd/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -694,6 +694,35 @@ def get_trusted_phone_numbers(self) -> Sequence[TrustedDevice]:

return parse_trusted_phone_numbers_response(response)

def trigger_push_notification(self) -> bool:
"""Triggers a push notification to trusted devices for 2FA code entry.

Sends PUT to /verify/trusteddevice/securitycode (no body). Apple's new
auth flow (2026+) uses this endpoint to push a code to trusted devices.
"""
headers = self._get_auth_headers({"Accept": "application/json"})
try:
if self.response_observer:
rules = list(
chain(
self.cookie_obfuscate_rules,
self.header_obfuscate_rules,
self.header_pass_rules,
self.header_drop_rules,
)
)
else:
rules = []

with self.use_rules(rules):
self.session.put(
f"{self.AUTH_ENDPOINT}/verify/trusteddevice/securitycode",
headers=headers,
)
return True
except PyiCloudAPIResponseException:
return False

def send_2fa_code_sms(self, device_id: int) -> bool:
"""Requests that a verification code is sent to the given device"""

Expand Down
13 changes: 9 additions & 4 deletions src/pyicloud_ipd/sms.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,17 @@ def parse_trusted_phone_numbers_payload(content: str) -> Sequence[TrustedDevice]
parser = _SMSParser()
parser.feed(content)
parser.close()
twoSV = parser.sms_data.get("direct", {}).get("twoSV", {})
numbers: Sequence[Mapping[str, Any]] = (
parser.sms_data.get("direct", {})
.get("twoSV", {})
.get("phoneNumberVerification", {})
.get("trustedPhoneNumbers", [])
twoSV.get("phoneNumberVerification", {}).get("trustedPhoneNumbers", [])
)
if not numbers:
# Apple moved trustedPhoneNumbers into bridgeInitiateData.phoneNumberVerification (2026+)
numbers = (
twoSV.get("bridgeInitiateData", {})
.get("phoneNumberVerification", {})
.get("trustedPhoneNumbers", [])
)
return list(item for item in map(_map_to_trusted_device, numbers) if item is not None)


Expand Down
27 changes: 27 additions & 0 deletions tests/vcr_cassettes/2fa_flow_invalid_code.yml
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,33 @@ interactions:
status:
code: 200
message: OK
- request:
body: null
headers:
Accept: ['application/json']
Accept-Encoding: ['gzip, deflate']
Connection: ['keep-alive']
Content-Length: ['0']
X-Apple-ID-Session-Id: ['session-1234567890']
X-Apple-OAuth-Client-Id: ['d39ba9916b7251055b22c7f910e2ea796ee65e98b2ddecea8f5dde8d9d1a815d']
X-Apple-OAuth-Client-Type: ['firstPartyAuth']
X-Apple-OAuth-Redirect-URI: ['https://www.icloud.com']
X-Apple-OAuth-Require-Grant-Code: ['true']
X-Apple-OAuth-Response-Mode: ['web_message']
X-Apple-OAuth-Response-Type: ['code']
X-Apple-OAuth-State: ['DE309E26-942E-11E8-92F5-14109FE0B321']
X-Apple-Widget-Key: ['d39ba9916b7251055b22c7f910e2ea796ee65e98b2ddecea8f5dde8d9d1a815d']
scnt: ['scnt-1234567890']
method: PUT
uri: https://idmsa.apple.com/appleauth/auth/verify/trusteddevice/securitycode
response:
body:
string: ''
headers:
Content-Type: ['application/json']
status:
code: 200
message: OK
- request:
body: !!python/unicode '{"securityCode": {"code": "901431"}}'
headers:
Expand Down
27 changes: 27 additions & 0 deletions tests/vcr_cassettes/2fa_flow_valid_code.yml
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,33 @@ interactions:
status:
code: 200
message: OK
- request:
body: null
headers:
Accept: ['application/json']
Accept-Encoding: ['gzip, deflate']
Connection: ['keep-alive']
Content-Length: ['0']
X-Apple-ID-Session-Id: ['session-1234567890']
X-Apple-OAuth-Client-Id: ['d39ba9916b7251055b22c7f910e2ea796ee65e98b2ddecea8f5dde8d9d1a815d']
X-Apple-OAuth-Client-Type: ['firstPartyAuth']
X-Apple-OAuth-Redirect-URI: ['https://www.icloud.com']
X-Apple-OAuth-Require-Grant-Code: ['true']
X-Apple-OAuth-Response-Mode: ['web_message']
X-Apple-OAuth-Response-Type: ['code']
X-Apple-OAuth-State: ['DE309E26-942E-11E8-92F5-14109FE0B321']
X-Apple-Widget-Key: ['d39ba9916b7251055b22c7f910e2ea796ee65e98b2ddecea8f5dde8d9d1a815d']
scnt: ['scnt-1234567890']
method: PUT
uri: https://idmsa.apple.com/appleauth/auth/verify/trusteddevice/securitycode
response:
body:
string: ''
headers:
Content-Type: ['application/json']
status:
code: 200
message: OK
- request:
body: !!python/unicode '{"securityCode": {"code": "654321"}}'
headers:
Expand Down
27 changes: 27 additions & 0 deletions tests/vcr_cassettes/2fa_flow_valid_code_zero_lead.yml
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,33 @@ interactions:
status:
code: 200
message: OK
- request:
body: null
headers:
Accept: ['application/json']
Accept-Encoding: ['gzip, deflate']
Connection: ['keep-alive']
Content-Length: ['0']
X-Apple-ID-Session-Id: ['session-1234567890']
X-Apple-OAuth-Client-Id: ['d39ba9916b7251055b22c7f910e2ea796ee65e98b2ddecea8f5dde8d9d1a815d']
X-Apple-OAuth-Client-Type: ['firstPartyAuth']
X-Apple-OAuth-Redirect-URI: ['https://www.icloud.com']
X-Apple-OAuth-Require-Grant-Code: ['true']
X-Apple-OAuth-Response-Mode: ['web_message']
X-Apple-OAuth-Response-Type: ['code']
X-Apple-OAuth-State: ['DE309E26-942E-11E8-92F5-14109FE0B321']
X-Apple-Widget-Key: ['d39ba9916b7251055b22c7f910e2ea796ee65e98b2ddecea8f5dde8d9d1a815d']
scnt: ['scnt-1234567890']
method: PUT
uri: https://idmsa.apple.com/appleauth/auth/verify/trusteddevice/securitycode
response:
body:
string: ''
headers:
Content-Type: ['application/json']
status:
code: 200
message: OK
- request:
body: !!python/unicode '{"securityCode": {"code": "054321"}}'
headers:
Expand Down