Fix ID replacements not being performed in style elements#59
Open
fortinmike wants to merge 2 commits intoiconfu:masterfrom
Open
Fix ID replacements not being performed in style elements#59fortinmike wants to merge 2 commits intoiconfu:masterfrom
fortinmike wants to merge 2 commits intoiconfu:masterfrom
Conversation
Author
|
Oh and by the way I also added a |
|
Great! Works on my app. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
svg-inject does not add suffixes to IDs located in style elements; it only replaces
url(#id)references. This breaks styles and animations such as those exported by SVGator due to "standalone" IDs not being suffixed, when themakeIdsUniqueoption is enabled.Fix
Replace the regex for id replacements in the style element with a more generalized one that matches
#idas well asurl(#id)(as before).Although this is a much more generalized regex, as far as I know this shouldn't cause issues with fancy CSS syntax.
Example
Original SVG
After injection with unfixed svg-inject
Styles stay exactly the same after injection, disconnecting styles from the now-suffixed elements in the SVG body.
After injection with this pull request