[new] Make groups collapsable#56
Open
pramodjodhani wants to merge 6 commits into
Open
Conversation
jamesckemp
reviewed
Aug 10, 2021
jamesckemp
left a comment
jamesckemp
left a comment
Contributor
There was a problem hiding this comment.
@pramodjodhani Please attach a video so I can see it in action
Member
Author
|
@jamesckemp
I will fix them soon. |
2. Delete header when row is deleted
Member
Author
|
@jamesckemp I have fixed the issues. It's back to you. |
mattwatsoncodes
requested review from
mattwatsoncodes
and removed request for
jamesckemp
mattwatsoncodes
approved these changes
Sep 24, 2021
mattwatsoncodes
left a comment
mattwatsoncodes
left a comment
Contributor
There was a problem hiding this comment.
Tested and works great 👍
Member
Author
|
@jamesckemp would you give it a final nod and maybe merge if all is good? |
Member
Author
|
Noticed more issues:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wsf-collapsable.mp4