Move Unity Dots features into an embedded UPM package #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves code related to features using Unity Dots (Burst/Jobs) into
Packages/OpenBrushToolkitDotsas an embedded UPM package.Motivation
If the recently added "Split Mesh By Stroke" tool is added to the
.unitypackage, and a user imports the package into their Unity project without Burst installed, it generates namespace errors in the Unity console. This happens because the Split Mesh By Stroke tool has Burst as a dependency, and.unitypackagefiles don't support dependencies.How it fixes the issue
UPM packages can have dependencies. The features using Unity Dots must now be installed manually. The user installs the OpenBrushToolkitDots package via the Package Manager via git URL.
Other Notes
Although we have pretty much decided that this open-brush-toolkit SDK should be in maintenance mode, any code for features using Unity Dots should go into
Packages/OpenBrushToolkitDots/