Skip to content

Update permission strings #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 5, 2025

Conversation

tangobravo
Copy link
Contributor

Use an empty string rather than "Not Used" for camera - the Zapbox SDK fills in a default if this is unset.

Add a descriptive permission string for microphone usage.

The microphone one in particular will likely come up in app review; it pops up straight away even before controllers are paired so the Apple reviewers will likely notice, and the quality of permission strings is often a reason for failed app reviews.

It would be better to delay requesting the permission until the microphone is actually used (I assume delaying photon voice until joining a room or something similar) but hopefully this is a quick fix that will get the update through review for now.

Use an empty string rather than "Not Used" for camera - the Zapbox SDK fills in a default if this is unset.

Add a descriptive permission string for microphone usage.
@tangobravo
Copy link
Contributor Author

Ah so the blank camera permission fails some test in the MacOS build, as it looks like "Webcam Texture" is in use there for something. Not sure how easy it is to make this value vary per-platform.

@mikeage
Copy link
Member

mikeage commented Apr 4, 2025

Note that we lost the Library/ caches for some of the Android platforms (and, I suppose, ios!) so the build is taking noticeably longer. I've rerun a build on main which should populate them, but it can take a few hours

Edit: caches are available; subsequent builds should be fast again

Mac build requires some text, so just go with a generic description that will work for iOS Zapbox build too
@mikeage mikeage merged commit 3ff9297 into icosa-foundation:main Apr 5, 2025
30 checks passed
@mikeage mikeage added the bugfix Something has been fixed label Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Something has been fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants