-
Notifications
You must be signed in to change notification settings - Fork 107
Reorderable classes in added courses pane #1554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Choollol
wants to merge
38
commits into
main
Choose a base branch
from
AA-903-reorder-added-courses
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 22 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
448b426
Optimize AddedSectionsGrid courses initialization
Choollol ee5c649
Move drag and drop components into higher level folder
Choollol 2bfec35
Move ScheduleSelect schedule reordering logic out of SortableList
Choollol a252df3
Add sx and disableHorizontalScroll props to SortableList
Choollol 1325dce
Implement added courses grid reordering (ephemeral)
Choollol 2925084
Create getCourseId utility
Choollol ebef1d0
Create moveArrayElement utility
Choollol 1be36e9
Save course ordering
Choollol 1a75259
Clean up handleCourseOrderChange
Choollol ae2fe90
Fix insert index
Choollol 9cab57b
Fix drag handle to work with mobile touch
Choollol b395dfc
Merge branch 'main' of https://github.com/icssc/AntAlmanac into AA-90…
Choollol 8d4846b
Update added courses reordering logic
Choollol 01ad30a
Use mergeSx instead of spreading sx
Choollol 520cb3d
Microoptimize course searching in AddedCoursePane
Choollol 72e1bbe
Use verticalListSortingStrategy
Choollol 8fb2e35
Merge branch 'main' of https://github.com/icssc/AntAlmanac into AA-90…
Choollol 9019578
Move handle to left side and change styles
Choollol 4ebd4ba
Merge branch 'main' of https://github.com/icssc/AntAlmanac into AA-90…
Choollol 9c4f8ee
Change drag handle to inherit color instead of hardcoded
Choollol d4e32e4
Merge branch 'main' of https://github.com/icssc/AntAlmanac into AA-90…
Choollol 3f8eee2
Fix missing moveArrayElements import
Choollol ea9c0e1
Merge branch 'main' of https://github.com/icssc/AntAlmanac into AA-90…
Choollol 3f689ec
Make cursor "grab" when hovering and dragging
Choollol b0eff19
Reset cursor when drag is cancelled
Choollol 94af198
Merge branch 'main' of https://github.com/icssc/AntAlmanac into AA-90…
Choollol 69e3afa
Fix missing import
Choollol 88a9f68
Merge branch 'main' of https://github.com/icssc/AntAlmanac into AA-90…
Choollol b221b3e
Store indexes of courses
Choollol fb55b4e
Fix drag icon being smaller than button
Choollol 0d5fec0
Delete unused SectionTableProps duplication
Choollol 02f8b60
Handle collapsible sortable items
Choollol 11c39c4
Merge branch 'main' of https://github.com/icssc/AntAlmanac into AA-90…
Choollol a9abd7c
Make draggingState nullable
Choollol 77e49db
Show grabbing cursor when dragging
Choollol e6453f0
Make missing sections part of collapsible
Choollol e8aade1
Treat null-index courses as equal
Choollol f937b3e
Fix horizontal scrolling behavior to be consistent with before
Choollol File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 1 addition & 2 deletions
3
...rc/components/RightPane/CoursePane/SearchForm/DepartmentSearchBar/DepartmentSearchBar.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 4 additions & 5 deletions
9
apps/antalmanac/src/components/RightPane/SectionTable/CourseInfo/CourseInfoBar.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.