feat: add filters to search results page by calebwongg · Pull Request #1588 · icssc/AntAlmanac

calebwongg · 2026-04-07T10:25:44Z

Summary

Add filters for each displayed course on the search results page. Filtering option persists across searches, but not across sessions

Test Plan

Check each filtering option and ensure that classes are sorted accordingly
Check filtering methods across multiple searches

Issues

Closes #937

alexespejo · 2026-04-10T02:00:48Z

I know this is still a draft but I don't think I see the purpose of sorting the individual class sections (granted I've only had to enroll in upper div cs classes). I can see another button being added to that top row where we can filter the classes against each other. Mb if this is redundant from a design discussion

calebwongg · 2026-04-14T08:03:50Z

@cubic hi

cubic-dev-ai · 2026-04-14T08:04:03Z

@cubic hi

@calebwongg Hi! I'm cubic. Here's how I can help with your PR:

Ask questions

@cubic why did you suggest this change?

Request reviews

@cubic review this - Run a code review

Give feedback

@cubic this suggestion doesn't work for our use case

Request fixes

@cubic fix this - Ask me to fix an issue. I can push commits to this PR or open a new PR; tell me which you want.

…/search-results-filter

cubic-dev-ai

No issues found across 5 files

cubic-dev-ai · 2026-04-14T22:55:26Z

@cubic

@calebwongg I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 5 files

alexespejo

I

cubic-dev-ai

1 issue found across 5 files (changes from recent commits).

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/antalmanac/src/components/RightPane/SectionTable/SectionTableBody/SectionTableBody.tsx">

<violation number="1" location="apps/antalmanac/src/components/RightPane/SectionTable/SectionTableBody/SectionTableBody.tsx:72">
P2: Handle GPA fetch failures in the `Promise.all` chain; one rejected request currently causes an unhandled rejection and aborts all GPA updates.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

calebwongg · 2026-04-21T08:31:19Z

@cubic

cubic-dev-ai · 2026-04-21T08:31:35Z

@cubic

@calebwongg I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 8 files

alexespejo · 2026-05-02T03:54:42Z

how's progress here

cubic-dev-ai

2 issues found across 4 files (changes from recent commits).

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/antalmanac/src/components/RightPane/CoursePane/CourseRenderPane.tsx">

<violation number="1" location="apps/antalmanac/src/components/RightPane/CoursePane/CourseRenderPane.tsx:504">
P1: GPA sorting performs per-instructor live grade queries (`cacheOnly=false`) in a large loop, which can trigger excessive API traffic.</violation>

<violation number="2" location="apps/antalmanac/src/components/RightPane/CoursePane/CourseRenderPane.tsx:505">
P2: The GPA mapping check uses truthiness, so a valid `averageGPA` of `0` is incorrectly discarded.</violation>
</file>

_{Tip: Review your code locally with the cubic CLI to iterate faster.}

cubic-dev-ai

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/antalmanac/src/components/RightPane/CoursePane/CourseRenderPane.tsx">

<violation number="1" location="apps/antalmanac/src/components/RightPane/CoursePane/CourseRenderPane.tsx:504">
P2: Using `cacheOnly=true` disables GPA fetch fallback and can leave GPA sorting incomplete when cache entries are missing.</violation>
</file>

_{Tip: Review your code locally with the cubic CLI to iterate faster.}

cubic-dev-ai · 2026-05-06T00:21:37Z

+                    if (requested.has(key)) continue;
+                    requested.add(key);
+                    tasks.push(
+                        Grades.queryGrades(course.deptCode, course.courseNumber, instructor, true)


P2: Using cacheOnly=true disables GPA fetch fallback and can leave GPA sorting incomplete when cache entries are missing.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At apps/antalmanac/src/components/RightPane/CoursePane/CourseRenderPane.tsx, line 504: <comment>Using `cacheOnly=true` disables GPA fetch fallback and can leave GPA sorting incomplete when cache entries are missing.</comment> <file context> @@ -491,18 +491,18 @@ export default function CourseRenderPane(props: { id?: number }) { tasks.push( - Grades.queryGrades(course.deptCode, course.courseNumber, instructor, false) - .then((grades) => (grades?.averageGPA ? { key, gpa: grades.averageGPA } : null)) + Grades.queryGrades(course.deptCode, course.courseNumber, instructor, true) + .then((grades) => (grades?.averageGPA != null ? { key, gpa: grades.averageGPA } : null)) .catch(() => null) </file context>

Suggested change

Grades.queryGrades(course.deptCode, course.courseNumber, instructor, true)

Grades.queryGrades(course.deptCode, course.courseNumber, instructor, false)

_{Tip: Review your code locally with the cubic CLI to iterate faster.}

everything displayed in the search pane should already be in the cache? because theres no way that classes can get added without requerying?

@alexespejo not sure if im misinterpreting me know your thoughts on this please :D

calebwongg added 6 commits April 6, 2026 02:23

visualization method

eed8eff

add mock filters / placeholders

d0c5976

add clear and delete logic

36d98a8

add search filter logic

4399bf9

add working test scripts

c127008

adjust sizing

63d6250

calebwongg temporarily deployed to staging-1588 April 7, 2026 10:25 — with GitHub Actions Inactive

github-actions Bot temporarily deployed to staging-1588 April 7, 2026 10:25 Inactive

change styling

d26ea78

calebwongg temporarily deployed to staging-1588 April 7, 2026 22:53 — with GitHub Actions Inactive

github-actions Bot temporarily deployed to staging-1588 April 7, 2026 22:53 Inactive

calebwongg added 2 commits April 7, 2026 15:58

adjust size of the filter button

cb999f0

display sort filter as all uppercase

62a787c

calebwongg temporarily deployed to staging-1588 April 7, 2026 23:05 — with GitHub Actions Inactive

github-actions Bot temporarily deployed to staging-1588 April 7, 2026 23:05 Inactive

calebwongg added 3 commits April 14, 2026 00:46

move search filter to course pane button row

6fa9bab

remove from sectiontable row

56ef37c

consistent styling

12507c5

calebwongg had a problem deploying to staging-1588 April 14, 2026 08:03 — with GitHub Actions Failure

github-actions Bot had a problem deploying to staging-1588 April 14, 2026 08:03 Failure

calebwongg marked this pull request as ready for review April 14, 2026 08:03

Merge branch 'main' of https://github.com/icssc/AntAlmanac into cwong…

71cbb09

…/search-results-filter

cubic-dev-ai Bot reviewed Apr 14, 2026

View reviewed changes

calebwongg temporarily deployed to staging-1588 April 14, 2026 08:06 — with GitHub Actions Inactive

github-actions Bot temporarily deployed to staging-1588 April 14, 2026 08:06 Inactive

calebwongg added 2 commits April 14, 2026 14:20

remove enrollment filter

d5f633a

update search options

80c5004

cubic-dev-ai Bot reviewed Apr 14, 2026

View reviewed changes

alexespejo reviewed Apr 20, 2026

View reviewed changes

Comment thread apps/antalmanac/src/components/RightPane/SectionTable/SectionTableBody/SectionTableBody.tsx Outdated

alexespejo reviewed Apr 20, 2026

View reviewed changes

Comment thread apps/antalmanac/src/stores/SectionFilterStore.ts

alexespejo reviewed Apr 20, 2026

View reviewed changes

Comment thread apps/antalmanac/src/stores/SectionFilterStore.ts Outdated

alexespejo requested changes Apr 20, 2026

View reviewed changes

calebwongg added 3 commits April 21, 2026 00:17

feat: search by gpa

9a27222

delete day filtering

b520f19

refactor grade query logic to avoid dupe queries and race conditions'

8f2fa33

calebwongg temporarily deployed to staging-1588 April 21, 2026 08:03 — with GitHub Actions Inactive

github-actions Bot temporarily deployed to staging-1588 April 21, 2026 08:04 Inactive

cubic-dev-ai Bot reviewed Apr 21, 2026

View reviewed changes

Comment thread apps/antalmanac/src/components/RightPane/SectionTable/SectionTableBody/SectionTableBody.tsx Outdated

prevent promise from failing on grade queries

962dec9

calebwongg temporarily deployed to staging-1588 April 21, 2026 08:26 — with GitHub Actions Inactive

github-actions Bot temporarily deployed to staging-1588 April 21, 2026 08:26 Inactive

cubic-dev-ai Bot reviewed Apr 21, 2026

View reviewed changes

calebwongg added 2 commits May 5, 2026 02:30

fix: merge conflicts

e05251e

feat: filter sorts whole courses instead of individual sections

2ffc12d

calebwongg temporarily deployed to staging-1588 May 5, 2026 23:31 — with GitHub Actions Inactive

github-actions Bot temporarily deployed to staging-1588 May 5, 2026 23:31 Inactive

cubic-dev-ai Bot reviewed May 5, 2026

View reviewed changes

Comment thread apps/antalmanac/src/components/RightPane/CoursePane/CourseRenderPane.tsx Outdated

Comment thread apps/antalmanac/src/components/RightPane/CoursePane/CourseRenderPane.tsx Outdated

calebwongg added 3 commits May 5, 2026 16:53

undo random prettier formats to clean diff

9e8d5e4

fix: set gpa filter hook to falback onto the cache

870d9f1

fix truthiness check on averagegpa

b1c0ca1

calebwongg deployed to staging-1588 May 6, 2026 00:18 — with GitHub Actions Active

github-actions Bot deployed to staging-1588 May 6, 2026 00:18 View deployment

cubic-dev-ai Bot reviewed May 6, 2026

View reviewed changes

	Grades.queryGrades(course.deptCode, course.courseNumber, instructor, true)
	Grades.queryGrades(course.deptCode, course.courseNumber, instructor, false)

Conversation

calebwongg commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Issues

Uh oh!

alexespejo commented Apr 10, 2026

Uh oh!

calebwongg commented Apr 14, 2026

Uh oh!

cubic-dev-ai Bot commented Apr 14, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot commented Apr 14, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alexespejo left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

calebwongg commented Apr 21, 2026

Uh oh!

cubic-dev-ai Bot commented Apr 21, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

alexespejo commented May 2, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot May 6, 2026

Choose a reason for hiding this comment

Uh oh!

calebwongg May 6, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

calebwongg commented Apr 7, 2026 •

edited

Loading