Conversation
Contributor
Author
Contributor
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 5 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/antalmanac/src/components/RightPane/CoursePane/CourseRenderPane.tsx">
<violation number="1" location="apps/antalmanac/src/components/RightPane/CoursePane/CourseRenderPane.tsx:358">
P2: `andSchoolCount` is recomputed from filtered flattened rows, which can misplace the OR banner when course filtering removes all AND courses from a school but leaves its header.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Contributor
Author
Contributor
Contributor
There was a problem hiding this comment.
1 issue found across 5 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/antalmanac/src/components/RightPane/CoursePane/SearchForm/AdvancedSearch/AdvancedSearchTextFields.tsx">
<violation number="1" location="apps/antalmanac/src/components/RightPane/CoursePane/SearchForm/AdvancedSearch/AdvancedSearchTextFields.tsx:160">
P2: Preserve the current pathname when replacing history; prepending `'/'` forces the URL to root and can break navigation context on non-root routes.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
…/AdvancedSearch/AdvancedSearchTextFields.tsx Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Contributor
Author
Contributor
xgraceyan
reviewed
May 5, 2026
Contributor
xgraceyan
left a comment
xgraceyan
left a comment
There was a problem hiding this comment.
Code LGTM currently besides a few small comments, but I would also test this after the Taken Courses filter/PP roadmap filter is back again just to make sure those two filters can work together. Also resolve merge conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allows students to search for courses that fulfill multiple GEs at once. It was decided during a meeting that to ensure confusion between if this feature is an AND or OR search, AND results would be displayed at the top and OR results would follow. The switch between AND/OR results is indicated by a warning label stating the courses listed below only include "at least ONE selected GE". (I might need a better phrase to communicate this though).
Legacy single GE search still works the same.
I also ensured a normalized url search query as well as compatibility with other existing manual search features (i wasn't able to test filter by roadmap since its broken rn but the fix is in an active pr).
Warning banner between the AND and OR results:
No results:
Test Plan
Issues
Closes #1610