Skip to content

feat: add optional text review field to review prompt#1679

Open
victorialee13 wants to merge 3 commits intomainfrom
feat/text-in-reviews
Open

feat: add optional text review field to review prompt#1679
victorialee13 wants to merge 3 commits intomainfrom
feat/text-in-reviews

Conversation

@victorialee13
Copy link
Copy Markdown
Contributor

@victorialee13 victorialee13 commented May 1, 2026

Summary

Adds a text field where users can write a review. Made it optional.

Untouched
image

Filled out for submission

image

Closes #1675

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Copy link
Copy Markdown
Contributor

@AureliaSindhu AureliaSindhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts of adding a character counter

difficulty: z.number().int().min(1).max(5),
tags: z.array(reviewTagsEnum).default([]),
anonymous: z.boolean().default(true),
content: z.string().optional(),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add max length

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set to 500 for now

Comment thread apps/antalmanac/src/stores/ReviewPromptStore.ts Outdated
@AureliaSindhu AureliaSindhu self-requested a review May 3, 2026 21:38
Copy link
Copy Markdown
Contributor

@AureliaSindhu AureliaSindhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see prev comments please, i accidentally approved it

fullWidth
value={textReview}
onChange={(e) => setTextReview(e.target.value)}
slotProps={{ htmlInput: { maxLength: 1000 } }}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't match backend (.max(500))

difficulty: z.number().int().min(1).max(5),
tags: z.array(reviewTagsEnum).default([]),
anonymous: z.boolean().default(true),
content: z.string().max(500).optional(),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sync with frontend, either 500 or 1000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support text in reviews

2 participants