Skip to content

Planner search followup#1684

Open
Choollol wants to merge 14 commits intomainfrom
planner-search-followup
Open

Planner search followup#1684
Choollol wants to merge 14 commits intomainfrom
planner-search-followup

Conversation

@Choollol
Copy link
Copy Markdown
Contributor

@Choollol Choollol commented May 2, 2026

Summary

Some followup changes to Search with Planner.

Test Plan

  • Search with planner works as before
  • Course search results are fetched and rendered correctly
  • Searching courses with many sections, like Bio 199 Spring 2026, doesn't cause any network errors (previously trpc was batching every single aggregateGrades request)

Issues

Closes #

@Choollol Choollol force-pushed the planner-search-followup branch from df0d74a to 01684f3 Compare May 2, 2026 17:56
@Choollol Choollol marked this pull request as ready for review May 2, 2026 19:41
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 3 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/antalmanac/src/components/RightPane/CoursePane/CourseRenderPane.tsx">

<violation number="1" location="apps/antalmanac/src/components/RightPane/CoursePane/CourseRenderPane.tsx:284">
P2: Reset `unofferedCourses` at the start of each query; otherwise stale “not offered” warnings can persist across searches.</violation>

<violation number="2" location="apps/antalmanac/src/components/RightPane/CoursePane/CourseRenderPane.tsx:331">
P2: Avoid mutating `useQuery` data in place; clone or transform immutably before applying section color/type fields.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 5 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/antalmanac/src/components/RightPane/CoursePane/SearchForm/SearchWithPlanner.tsx">

<violation number="1" location="apps/antalmanac/src/components/RightPane/CoursePane/SearchForm/SearchWithPlanner.tsx:154">
P3: The new ellipsis styling is incomplete; add no-wrap so long roadmap names actually truncate with `...`.</violation>
</file>

Tip: Review your code locally with the cubic CLI to iterate faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant