Conversation
df0d74a to
01684f3
Compare
Contributor
There was a problem hiding this comment.
2 issues found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/antalmanac/src/components/RightPane/CoursePane/CourseRenderPane.tsx">
<violation number="1" location="apps/antalmanac/src/components/RightPane/CoursePane/CourseRenderPane.tsx:284">
P2: Reset `unofferedCourses` at the start of each query; otherwise stale “not offered” warnings can persist across searches.</violation>
<violation number="2" location="apps/antalmanac/src/components/RightPane/CoursePane/CourseRenderPane.tsx:331">
P2: Avoid mutating `useQuery` data in place; clone or transform immutably before applying section color/type fields.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Contributor
There was a problem hiding this comment.
1 issue found across 5 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/antalmanac/src/components/RightPane/CoursePane/SearchForm/SearchWithPlanner.tsx">
<violation number="1" location="apps/antalmanac/src/components/RightPane/CoursePane/SearchForm/SearchWithPlanner.tsx:154">
P3: The new ellipsis styling is incomplete; add no-wrap so long roadmap names actually truncate with `...`.</violation>
</file>
Tip: Review your code locally with the cubic CLI to iterate faster.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some followup changes to Search with Planner.
Test Plan
aggregateGradesrequest)Issues
Closes #