Skip to content

Convert planner hook into zustand store#1693

Open
Choollol wants to merge 3 commits intomainfrom
1646-planner-store
Open

Convert planner hook into zustand store#1693
Choollol wants to merge 3 commits intomainfrom
1646-planner-store

Conversation

@Choollol
Copy link
Copy Markdown
Contributor

@Choollol Choollol commented May 3, 2026

Summary

Test Plan

  • Planner data is fetched correctly without any errors
  • Planner features still work, like filtering courses and search with Planner

Issues

Closes #1646

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 8 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/antalmanac/src/components/RightPane/CoursePane/SearchForm/AdvancedSearch/AdvancedSearchTextFields.tsx">

<violation number="1" location="apps/antalmanac/src/components/RightPane/CoursePane/SearchForm/AdvancedSearch/AdvancedSearchTextFields.tsx:185">
P1: Calling `updateTakenCourses` on selection change without clearing it in the invalid-roadmap reset path can leave stale taken-course filtering enabled after the UI resets the selection.</violation>
</file>

<file name="apps/antalmanac/src/stores/PlannerStore.ts">

<violation number="1" location="apps/antalmanac/src/stores/PlannerStore.ts:71">
P1: Clear `plannerRoadmaps` when roadmap fetch fails to avoid serving stale roadmap data after an error.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment thread apps/antalmanac/src/stores/PlannerStore.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor planner hook

1 participant