feat: store the term the dismissal is from

[KevinWu098]

Summary

Although a review per (course, professor) combo is usually sufficient, we do care which term a review OR a dismissal comes from for accuracy.

Therefore, we need to store it and declare that they are unique based on term. For existing dismissals which do not have terms, a manual backfill has been written into the SQL migration.

Test Plan

Issues

Closes #

[cubic-dev-ai]

1 issue found across 7 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/antalmanac/src/stores/ReviewPromptStore.ts">

<violation number="1" location="apps/antalmanac/src/stores/ReviewPromptStore.ts:90">
P1: Guard `course.section.instructors` before calling `.at(0)` to avoid a runtime error when instructor data is missing.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

P1: Guard course.section.instructors before calling .at(0) to avoid a runtime error when instructor data is missing.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At apps/antalmanac/src/stores/ReviewPromptStore.ts, line 90:

<comment>Guard `course.section.instructors` before calling `.at(0)` to avoid a runtime error when instructor data is missing.</comment>

<file context>
@@ -87,8 +87,8 @@ export const useReviewPromptStore = create(
 
-                const instructor = course.section.instructors?.[0];
-                if (!instructor) {
+                const instructor = course.section.instructors.at(0)?.trim();
+                if (!instructor || instructor === 'STAFF') {
                     continue;
</file context>

Suggested change

	const instructor = course.section.instructors.at(0)?.trim();
	const instructor = course.section.instructors?.at(0)?.trim();