Soft delete DB rows#1820
Draft
xgraceyan wants to merge 7 commits into
Draft
Conversation
KevinWu098
reviewed
May 19, 2026
| @@ -0,0 +1,6 @@ | |||
| ALTER TABLE "schedules" ADD COLUMN "archived_at" timestamp with time zone;--> statement-breakpoint | |||
| ALTER TABLE "schedules" ALTER COLUMN "index" DROP NOT NULL;--> statement-breakpoint | |||
| ALTER TABLE "schedules" ADD CONSTRAINT "schedules_archive_index_consistency" CHECK ( | |||
Member
There was a problem hiding this comment.
this index consistency crap (which i know isn't your introduction) is absolutely hellish.
Contributor
Author
There was a problem hiding this comment.
What would you recommend then? Maybe we can make the unique index only apply to active rows then that would remove the need for the consistency check
Member
There was a problem hiding this comment.
dunno, i need to think/research it more — i just think that any time we do a constraint which isn't enforced by drizzle, we're really playing with fire
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
Issues
Closes #1698