[WIP] Friends PR-2: Friend schedule dialog#1856
Draft
brelieu05 wants to merge 6 commits into
Draft
Conversation
7 tasks
c45c142 to
eca99cf
Compare
Add friend-only tab context, controlled map location, and scope-aware quick search so the friend schedule dialog is self-contained on top of PR1. Co-authored-by: Cursor <cursoragent@cursor.com>
…ner leak warning Many schedule UI components subscribe through friendScheduleViewSource, which previously registered each callback directly on FriendsStore and exceeded the default EventEmitter listener limit.
ee3a276 to
4bbce1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implementation of Friend Dialog and dealing with read-only + omitting features + ensuring reuse of existing calendar UI.
FriendsStore— Holds friend schedule data separately from AppStore. Fetches via trpc.schedule.getFriendUserData and drives dialog open/close/loading state.friendScheduleViewSource— Read-only ScheduleViewSource (scope: 'friend') wired through a new FriendScheduleViewProvider, so ScheduleCalendar, toolbar, and event popover render friend data without touching the user's home schedule.FriendScheduleDialog→FriendScheduleView(split calendar + course list on desktop, stacked on mobile). Includes a read-only FriendSchedule course list with schedule notes.Intentional Things Omitted from this PR and will go into PR3
FriendScheduleEntry.tsxis a thin placeholder UI. It is immediately deleted in PR3Test Plan
Issues
Depends on #1850
Closes #