Skip to content

feat: ✨ adding queries for meeting cards + styling page UI#433

Merged
Windslash123 merged 22 commits into
mainfrom
aa/meeting-page-ui
May 6, 2026
Merged

feat: ✨ adding queries for meeting cards + styling page UI#433
Windslash123 merged 22 commits into
mainfrom
aa/meeting-page-ui

Conversation

@Windslash123

@Windslash123 Windslash123 commented Apr 26, 2026

Copy link
Copy Markdown
Contributor

Description

Matched meeting page UI to Figma design: added Action Required and Upcoming sections, reworked meeting cards, and added query functions for responder and scheduled meeting data.

Added mobile nav header for meetings page -- note: Notification icon om mobile currently doesn't open up anything, will be implemented in my next issue.

Recording/Screenshots

Meetings Page: Desktop

Before

Screenshot 2026-04-25 at 7 02 09 PM

After

Landing page with no meetings:
image

Unscheduled tab:

Screenshot 2026-05-04 at 10 13 07 PM

Scheduled tab:

Screenshot 2026-05-04 at 9 24 04 PM

Meetings Page: Mobile

Before

image

After

image

Test Plan

Issues

@Windslash123 Windslash123 temporarily deployed to staging-433 April 26, 2026 02:02 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-433 April 26, 2026 02:02 Inactive
@Windslash123 Windslash123 marked this pull request as ready for review April 30, 2026 20:11
@Windslash123 Windslash123 marked this pull request as draft April 30, 2026 20:11

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 issues found across 6 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/components/summary/meetings.tsx">

<violation number="1" location="src/components/summary/meetings.tsx:53">
P2: The meetings list lost explicit `createdAt` sorting, so card order is now non-deterministic.</violation>
</file>

<file name="src/components/ui/meeting-card.tsx">

<violation number="1" location="src/components/ui/meeting-card.tsx:77">
P2: This renders a clickable IconButton with no behavior, which creates a non-functional UI control. Use a non-interactive wrapper (or wire a real action) so users aren’t presented with a dead button.</violation>
</file>

<file name="src/lib/meeting-card/mapper.ts">

<violation number="1" location="src/lib/meeting-card/mapper.ts:29">
P2: Date formatting uses local timezone, which can shift stored calendar dates by one day for some users. Format these date-only meeting values in UTC to keep the intended day stable.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment thread src/components/summary/meetings.tsx
Comment thread src/components/ui/meeting-card.tsx
Comment thread src/lib/meeting-card/mapper.ts
@Windslash123 Windslash123 temporarily deployed to staging-433 April 30, 2026 21:05 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-433 April 30, 2026 21:05 Inactive
@Windslash123 Windslash123 temporarily deployed to staging-433 April 30, 2026 21:19 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-433 April 30, 2026 21:19 Inactive
@Windslash123

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai

@cubic-dev-ai

cubic-dev-ai Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai

@Windslash123 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 issues found across 6 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/components/ui/meeting-card.tsx">

<violation number="1" location="src/components/ui/meeting-card.tsx:159">
P2: Location is hardcoded to "LOCATION", so cards cannot render the actual meeting location.</violation>
</file>

<file name="src/components/summary/meetings.tsx">

<violation number="1" location="src/components/summary/meetings.tsx:177">
P2: The main meetings (“All”) grid is hidden on mobile and replaced with a different "Action Required" section, so mobile no longer mirrors the desktop meetings presentation.

(Based on your team's feedback about keeping the “All” section visible on mobile and mirroring desktop layout.) [FEEDBACK_USED]</violation>
</file>

<file name="src/lib/meeting-card/mapper.ts">

<violation number="1" location="src/lib/meeting-card/mapper.ts:31">
P1: Date formatting is timezone-dependent and can display the wrong calendar day. Format meeting dates in UTC to keep stored meeting dates stable across user timezones.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment thread src/lib/meeting-card/mapper.ts
Comment thread src/components/ui/meeting-card.tsx Outdated
Comment thread src/components/summary/meetings.tsx Outdated
@Windslash123 Windslash123 temporarily deployed to staging-433 April 30, 2026 21:33 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-433 April 30, 2026 21:33 Inactive
@Windslash123 Windslash123 temporarily deployed to staging-433 April 30, 2026 21:36 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-433 April 30, 2026 21:36 Inactive
@Windslash123 Windslash123 temporarily deployed to staging-433 April 30, 2026 21:39 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-433 April 30, 2026 21:39 Inactive
@Windslash123 Windslash123 temporarily deployed to staging-433 April 30, 2026 21:51 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-433 April 30, 2026 21:52 Inactive
@Windslash123 Windslash123 temporarily deployed to staging-433 May 2, 2026 00:46 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-433 May 2, 2026 00:46 Inactive
Windslash123 and others added 2 commits May 4, 2026 22:30
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
@Windslash123 Windslash123 temporarily deployed to staging-433 May 5, 2026 05:31 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-433 May 5, 2026 05:32 Inactive
@Windslash123 Windslash123 temporarily deployed to staging-433 May 5, 2026 05:34 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-433 May 5, 2026 05:34 Inactive
@Windslash123 Windslash123 temporarily deployed to staging-433 May 5, 2026 05:43 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-433 May 5, 2026 05:44 Inactive

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/components/summary/meetings.tsx">

<violation number="1" location="src/components/summary/meetings.tsx:248">
P2: Add an accessible label to the icon-only mobile create button (`IconButton`) so it is announced correctly by screen readers.</violation>
</file>

Tip: Review your code locally with the cubic CLI to iterate faster.

Comment thread src/components/summary/meetings.tsx
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
@Windslash123 Windslash123 temporarily deployed to staging-433 May 5, 2026 05:46 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-433 May 5, 2026 05:46 Inactive
@Windslash123 Windslash123 requested a review from ethancha0 May 5, 2026 05:48
@ethancha0

Copy link
Copy Markdown
Collaborator

bros going to cat cafes and color me mine

@ethancha0

Copy link
Copy Markdown
Collaborator

question: is "action required" implemented? it's mentioned in the pr description, however missing from the pictures and smoke test

@ethancha0

Copy link
Copy Markdown
Collaborator

thought: there should be a better way to sort the meeting cards. for example, move action required meetings to the top, followed by scheduled meetings, then unscheduled

this can be resolved in a future issue however

Comment on lines +196 to +205
if (activeFilter === "unscheduled") {
return (
<MeetingSection
label="Action Required"
meetings={displayMeetings}
meetingCounts={meetingCounts}
scheduledLabels={scheduledLabels}
/>
);
}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: the label is action required, but the filter displays unscheduled meetings.

Action required meetings should be reserved for meetings where availability hasn't been added
Unscheduled meetings are just meetings that hasn't been scheduled, regardless of inputted availability

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, forgot to use the needsAvailability filter instead here -- updated it, should be working now!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Comment thread src/components/summary/meetings.tsx Outdated
@Windslash123 Windslash123 temporarily deployed to staging-433 May 5, 2026 21:22 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-433 May 5, 2026 21:22 Inactive
@Windslash123 Windslash123 temporarily deployed to staging-433 May 5, 2026 21:25 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-433 May 5, 2026 21:25 Inactive

@ethancha0 ethancha0 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job arshiadadeer!

                          ....
                  .: :..:::::'
               ..:.::''''  '''     .. . .
             .':: ::''  .. ..   .::'' '''
              ':::' .::.'::  .'..::::::.
           ..:.::::: '.. :.'.:'''
     ...:'''  '':'::':'   ''
    :^ ^  'o>   .:'''
    :..'        '.
     '''''::    ':             .........
          :     :.       ...::''' ' ' '''::.
        .::     ':::.:':'''''            :::':.
       .::'                             :::
       ::'                              ::. ...::.
      .::'                        .      '''.' . :.
      '::.                       ::... .  .'.''':::.
       ':.                   ....:::::':::::.    ':::..
       .:'         .:'.:.'::::::' '        ':::..  ':::::.
  ....:::::..     .:::::::'' '                 '':.    '':'
.':.:.:::::::'. ...:: ''

.'.'' .':'::'
.::' .''::

@Windslash123 Windslash123 merged commit 706c45a into main May 6, 2026
2 checks passed
@Windslash123 Windslash123 deleted the aa/meeting-page-ui branch May 20, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Meeting Page UI

2 participants