Cleanup#61
Merged
Priyansh4444 merged 8 commits intomasterfrom Jan 12, 2026
Merged
Conversation
| ); | ||
| } catch (error) { | ||
| console.log(error); | ||
| console.log("Failed to send verification code."); |
Member
There was a problem hiding this comment.
for this there is console.error and also i was wondering if you could just try adding a posthog thing instead a log is no longer useful :(
| } else { | ||
| statusLabel = "Found"; | ||
| } | ||
| const dateLabel = item.date || item.itemDate || "Unknown date"; |
Member
There was a problem hiding this comment.
confused at the difference of itemDate and item.date, a comment would be helpful in the DB 😔
Comment on lines
+27
to
+31
| export function formatDate(dateString: string) { | ||
| const yearMonthDateSchema = z.string().regex(/^\d{4}-\d{2}-\d{2}$/); | ||
| let date; | ||
| if (dateString) { | ||
| if (yearMonthDateSchema.safeParse(dateString).success) { |
Member
There was a problem hiding this comment.
The function definition should Option<dateString> or dateString|undefined if it requires and if check to be validated
Collaborator
Author
There was a problem hiding this comment.
Removed null checks since original checks in code were actually not needed based on schema's non-null constraints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.