Skip to content

Preview Navbar#1071

Merged
MajdKatabi merged 7 commits intomainfrom
preview-navbar
May 7, 2026
Merged

Preview Navbar#1071
MajdKatabi merged 7 commits intomainfrom
preview-navbar

Conversation

@MajdKatabi
Copy link
Copy Markdown
Member

Description

Screenshots

Test Plan

Issues

Closes #

@MajdKatabi MajdKatabi temporarily deployed to staging-1071 April 15, 2026 22:07 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-1071 April 15, 2026 22:08 Inactive
Copy link
Copy Markdown
Collaborator

@CadenLee2 CadenLee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend getting rid of the absolute position of the preview navbar, and instead letting it flow naturally with the rest of the flex items. Reference the image below (note how it's not exactly in the center, but instead has an equal margin on the left and right).

This is to reduce the likelihood of overlap with the course names on small screens (see code comment on media query)

Image

Comment thread site/src/component/ResultPreview/ProfessorPreview.tsx Outdated
Comment thread site/src/component/ResultPreview/ResultPreview.scss Outdated
Comment thread site/src/component/ResultPreview/PreviewNavBar.tsx Outdated
@MajdKatabi MajdKatabi temporarily deployed to staging-1071 April 20, 2026 22:47 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-1071 April 20, 2026 22:47 Inactive
@MajdKatabi MajdKatabi temporarily deployed to staging-1071 April 22, 2026 10:37 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-1071 April 22, 2026 10:38 Inactive
@MajdKatabi MajdKatabi temporarily deployed to staging-1071 April 22, 2026 10:45 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-1071 April 22, 2026 10:46 Inactive
@MajdKatabi MajdKatabi temporarily deployed to staging-1071 May 6, 2026 20:27 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-1071 May 6, 2026 20:28 Inactive
@MajdKatabi MajdKatabi temporarily deployed to staging-1071 May 6, 2026 20:34 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-1071 May 6, 2026 20:34 Inactive
Copy link
Copy Markdown
Collaborator

@CadenLee2 CadenLee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out further, the short pages issue does exist but is minor enough that it can be addressed in a follow-up. LGTM

@MajdKatabi MajdKatabi temporarily deployed to staging-1071 May 7, 2026 00:58 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-1071 May 7, 2026 00:58 Inactive
@MajdKatabi MajdKatabi merged commit 734c7d3 into main May 7, 2026
3 checks passed
@MajdKatabi MajdKatabi deleted the preview-navbar branch May 7, 2026 01:17
JasonNguyen067 pushed a commit that referenced this pull request May 9, 2026
* setup preview navbar (no mobile)

* fix styling + switch to id prop

* first draft mobile arrow navigation

* horizontal preview navbar mobile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants