-
Notifications
You must be signed in to change notification settings - Fork 35
Mobile popup improvement #1096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JasonNguyen067
wants to merge
18
commits into
main
Choose a base branch
from
mobilePopupImprovement
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Mobile popup improvement #1096
Changes from 4 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
c41278c
border + scroll fix
JasonNguyen067 926ed6f
height of popup
JasonNguyen067 3c31dd2
swipe down for removal of popup
JasonNguyen067 35a9366
Merge branch 'main' into mobilePopupImprovement
JasonNguyen067 1fcea92
Merge branch 'main' into mobilePopupImprovement
JasonNguyen067 4bb2f2f
bg swipedown + only swipedown on popup when scroll at default
JasonNguyen067 f355469
Merge branch 'main' into mobilePopupImprovement
JasonNguyen067 26a6e37
fix
JasonNguyen067 8e7d75d
Merge branch 'main' into mobilePopupImprovement
JasonNguyen067 0e2c35c
fix: allow scrolling at top of popup
CadenLee2 47e95e2
Merge branch 'main' into mobilePopupImprovement
JasonNguyen067 18cc119
hide cancel bar when swiping
JasonNguyen067 c2d64ae
Merge branch 'main' into mobilePopupImprovement
JasonNguyen067 495b3ad
Merge branch 'main' into mobilePopupImprovement
JasonNguyen067 337611e
Merge branch 'main' into mobilePopupImprovement
JasonNguyen067 a4feedf
Merge branch 'main' of https://github.com/icssc/peterportal-client in…
CadenLee2 428e07d
fix: mobile popup collapse for previews
CadenLee2 e2708e3
fix: disable scroll reload action
CadenLee2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.