Catalog years - #1204
Draft
CadenLee2 wants to merge 6 commits into
Draft
Conversation
* Integrate catalog years into major/minor endpoints * Cleanup for catalog yrs
* Integrate catalog years into major/minor endpoints (#1190) * Integrate catalog years into major/minor endpoints * Cleanup for catalog yrs * create initial redux slice to store catalog year * include catalogYearReducer in store.ts * update slice to associate catalog year with major * include catalog year in endpoint * add setALlCatalogYears reducer for loading multiple catalog years * Update catalog year types to string * feat: include catalog years in course requirements slice * remove catalogYearSlice * remove catalogYearSlice from store.ts * feat: catalog year dropdown + include catalog year in major course requirement fetch * feat: options for catalog years from the past 5 years * feat: use a current year for catalog year * feat: catalog years for minors * fix minors not including catalog year when fetching * replace default dropdown arrow icon * feat: catalog year tooltip * move catalog year constants to courseRequirements.ts * feat: include warning if a catalog year isn't available * feat: extract year formatting into courseRequirements.ts + comments * feat: add catalog year warning for minor course list * fix: warning not rendering again on resize * fix: include fallbackCatalogYear in major/minor mapping * feat: warning text and formatting updates * create initial redux slice to store catalog year * include catalogYearReducer in store.ts * update slice to associate catalog year with major * include catalog year in endpoint * add setALlCatalogYears reducer for loading multiple catalog years * feat: include catalog years in course requirements slice * remove catalogYearSlice * remove catalogYearSlice from store.ts * feat: catalog year dropdown + include catalog year in major course requirement fetch * feat: options for catalog years from the past 5 years * feat: use a current year for catalog year * feat: catalog years for minors * fix minors not including catalog year when fetching * replace default dropdown arrow icon * feat: catalog year tooltip * move catalog year constants to courseRequirements.ts * feat: include warning if a catalog year isn't available * feat: extract year formatting into courseRequirements.ts + comments * feat: add catalog year warning for minor course list * fix: warning not rendering again on resize * fix: include fallbackCatalogYear in major/minor mapping * feat: warning text and formatting updates * fix: warning not showing because of nulled fallback catalog year * address code comments - fix tooltip hover + specify tooltip message between major/minor --------- Co-authored-by: Anthony Jenanian <55033931+anthonyj33@users.noreply.github.com> Co-authored-by: Atticus Wong <atile4>
…to catalog-years
…to catalog-years
* refactor: catalog years component * feat: implement redesigned catalog year switcher * refactor: remove unused code * chore: remove unnecessary comment * feat: larger font size for catalog years select * tooltip grammar --------- Co-authored-by: Anthony Jenanian <55033931+anthonyj33@users.noreply.github.com>
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Wait to merge this until Anteater API has the requirements for 2026-27 for most majors
Support major and minor catalog years. This is the product of several PRs.
Description
Catalog years are now associated with majors and minors. The year can be chosen by a dropdown in the catalog, which then displays the correct data from Anteater API.
Screenshots
Test Plan
Issues
Closes #1154 #1153 #1144