Dove modifications part 2 #424
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What issue does this change request address?
#386
What are the significant changes in functionality due to this change request?
These changes implement a rough draft of HERON using DOVE to handle dispatch in the inner. The majority of the manual testing on these changes was performed using the https://github.com/idaholab/HERON/blob/devel/doc/workshop/LM2Tutorial/Full/heron_input_solution.xml input script, so that input is most likely to behave as expected. Note the typo in the input file (see changes in this PR). Significant organization and cleanup is necessary on this branch, but it is a working example for many main use cases of HERON. This branch of HERON is designed to pair with the branch of DOVE at https://github.com/caleb-sitton-inl/DOVE/tree/heron-compatibility-changes, so ensure that this is the current branch of DOVE when testing this version of HERON.
This branch of HERON is currently limited in its functionality. The following is a list of all the known assumptions and restrictions:
<comp>.is_governed()returns True) are not supported.<cf>.is_mult_target()returns True) are not supported.debug_mode = Trueis no longer operable.driveron repeating cashflows with periods that are not 'yearly' (these are the cashflows relevant to dispatch) must contain theactivitysubnode. DOVE expects every cashflow driver to be directly proportional to the activity of its respective component at every timestep; thus,drivermay containactivityand some additional, potentially time-varying multiplication factor. Most often, this factor will be in the form of amultiplier.scaling_factor_xon cashflows relevant to dispatch must be a constant value in time.activityValuedParam, nor can they be dependent on other quantities that are optimized by DOVE (e.g., storage levels, charge, discharge, etc).For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.