node-to-elem-map cleanup#32745
Draft
lindsayad wants to merge 9 commits intoidaholab:nextfrom
Draft
Conversation
The semilocal map's only consumers were the boundary-restricted node integrity checks, which are diagnostic-only. The underlying libMesh is_semilocal() method is itself discouraged in favour of the newer ghosting functor definitions. Replace all uses with the ordinary nodeToElemMap(). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Job Documentation, step Docs: sync website on a2f12ee wanted to post the following: View the site here This comment will be updated on new commits. |
Contributor
|
Job Coverage, step Generate coverage on f4fdee6 wanted to post the following: Framework coverage
Modules coverageCoverage did not change Full coverage reportsReports
This comment will be updated on new commits. |
||||||||||||||||||||||||||
All callers use key lookup or iterate locally without requiring MPI-consistent ordering (NodePositions sorts after allgather), so ordered traversal is not needed. Use auto at local variable call sites. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
lindsayad
changed the title
lindsayad
force-pushed
the
assert-things-built-32711
branch
3 times, most recently
from
325058a to
09e4c02
Compare
Replace the two phase_field uses (FeatureFloodCount::expandPointHalos and EBSDReader::buildNodeWeightMaps) with nodeToElemMap(). Rather than asserting the map is pre-built in addQuadratureNode, simply call nodeToElemMap() there directly -- it is a no-op if already built, and ensures a complete map before inserting the quadrature node if not. This removes the need for the upfront pre-requests that were added to NearestNodeLocator and PenetrationLocator in idaholab#32711, so those are removed too. Drop the now-gone PerfGraph timing section from the TestHarness JSON gold and cache files. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
lindsayad
force-pushed
the
assert-things-built-32711
branch
from
09e4c02 to
9b5b101
Compare
lindsayad
added a commit
to lindsayad/blackbear
that referenced
this pull request
Apr 12, 2026
lindsayad
added a commit
to lindsayad/mastodon
that referenced
this pull request
Apr 13, 2026
FEProblemBase::meshChanged() calls _geometric_search_data.reinit() after firing all the MeshChangedInterface callbacks — so NNL::reinit() -> PL::reinit() > detectPenetration() was already happening on every mesh change before the NodeFaceConstraint::meshChanged() override existed. The override was redundant.
lindsayad
force-pushed
the
assert-things-built-32711
branch
from
9b5b101 to
a2f12ee
Compare
Contributor
|
Job Test, step Results summary on a2f12ee wanted to post the following: Framework test summaryCompared against 953c577 in job civet.inl.gov/job/3779372. Added tests
Modules test summaryCompared against 953c577 in job civet.inl.gov/job/3779372. No change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on to #32711
std::maptostd::unordered_maprefs #32747