Namespace all of MOOSE-MFEM#32783
Draft
lindsayad wants to merge 2 commits intoidaholab:nextfrom
Draft
Conversation
lindsayad
changed the title
lindsayad
force-pushed
the
namespace-32782
branch
from
103ba80 to
fa46d76
Compare
We create new Solvers syntax such that users may specify both nonlinear and linear solvers within the same top-level syntax block. This commit also includes capability for using PETSc as the nonlinear solver backend
Move all MFEM framework classes into the Moose::MFEM namespace (e.g. MFEMKernel -> Moose::MFEM::Kernel) across headers, sources, and unit tests. Key changes: - All class definitions in framework/include/mfem/ and framework/src/mfem/ are now inside namespace Moose::MFEM with redundant Moose::MFEM:: qualifications stripped within those blocks - MFEMProblemData struct namespaced to Moose::MFEM::ProblemData - MFEMProblemSolve: class Executioner; forward declaration moved outside the namespace block - Moose.C task registration tokens updated to match registerBase values (Moose::MFEM::FESpace, Moose::MFEM::SubMesh, etc.) - Factory name strings (e.g. "MFEMFoo") preserved throughout MFEMProblem.C; solverTypeString() returns the factory name via type() - MFEM string parameter types (ScalarCoefficientName, VectorCoefficientName, MatrixCoefficientName, FESpaceName, SolverName) moved to Moose::MFEM namespace using new MooseDerivativeStringClassInNamespace macro; MooseDerivativeStringClass refactored to share body via MOOSE_DERIVATIVE_STRING_CLASS_IMPL helper to avoid duplication - Unit test C++ type usages updated to Moose::MFEM::Foo; TEST_F test name identifiers left unchanged Closes idaholab#32782 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
lindsayad
force-pushed
the
namespace-32782
branch
from
fa46d76 to
8249b42
Compare
lindsayad
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #32782