Skip to content

remove staggered pressure optional parameter #32832

Open
kyriv1980 wants to merge 1 commit intoidaholab:nextfrom
kyriv1980:staggered
Open

remove staggered pressure optional parameter #32832
kyriv1980 wants to merge 1 commit intoidaholab:nextfrom
kyriv1980:staggered

Conversation

@kyriv1980
Copy link
Copy Markdown
Contributor

This PR resolves issue #32797

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a1d1e07958

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread modules/subchannel/src/problems/SubChannel1PhaseProblem.C
@moosebuild
Copy link
Copy Markdown
Contributor

Job Test, step Results summary on 594f4f4 wanted to post the following:

Framework test summary

Compared against 162e78c in job civet.inl.gov/job/3769471.

No change

Modules test summary

Compared against 162e78c in job civet.inl.gov/job/3769471.

Removed tests

Test Time (s) Memory (MB)
subchannel/test:problems/psbt.psbt_regression_test_explicit_staggered 1.50 153.65

No added tests

@moosebuild
Copy link
Copy Markdown
Contributor

Job Documentation, step Docs: sync website on 594f4f4 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Copy Markdown
Contributor

Job Coverage, step Generate coverage on 594f4f4 wanted to post the following:

Framework coverage

Coverage did not change

Modules coverage

Subchannel

162e78 #32832 594f4f
Total Total +/- New
Rate 93.27% 94.18% +0.90% 100.00%
Hits 6144 6128 -16 65
Misses 443 379 -64 0

Diff coverage report

Full coverage report

Full coverage reports

Reports

This comment will be updated on new commits.

@GiudGiud
Copy link
Copy Markdown
Contributor

GiudGiud commented Apr 28, 2026

You should be able to make a separate standalone PR to the VTB to fix that failure (just delete the parameter setting)

@kyriv1980
Copy link
Copy Markdown
Contributor Author

@GiudGiud you plan to merge this when all test pass?

@GiudGiud
Copy link
Copy Markdown
Contributor

I plan to review it

what s the motivation for removing this? Is it not working as expected?
Staggering the pressure DOFs is a common technique to avoid oscillations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants