Jacobian and stabilization improvement#32836
Conversation
|
Clearly something I have messed up from seeing thousands of 'commits.' |
|
You rebased/based your PR off of the master branch. You should base it off of the devel branch. The laziest fix you can do here: git fetch upstream
git reset --hard upstream/devel
git cherry-pick d8101d514b8c3947de10b67c54d02f7a396957f1
git cherry-pick 9064a411130543677af50b3ad9d30aee695030f4
git push -fThis will reset to devel and then pull in your two commits. |
|
Job Documentation, step Docs: sync website on 5e77e9f wanted to post the following: View the site here This comment will be updated on new commits. |
lingzou
force-pushed
the
Jacobian-and-stabilization-improvement
branch
from
9064a41 to
972ad7c
Compare
…update test results Closes idaholab#32835
lingzou
force-pushed
the
Jacobian-and-stabilization-improvement
branch
from
972ad7c to
5e77e9f
Compare
|
Job Test, step Results summary on 5e77e9f wanted to post the following: Framework test summaryCompared against 4e53b3b in job civet.inl.gov/job/3786076. No change Modules test summaryCompared against 4e53b3b in job civet.inl.gov/job/3786076. No change |
|
Job Coverage, step Generate coverage on 5e77e9f wanted to post the following: Framework coverage
Modules coverageNavier stokes
Full coverage reportsReports
This comment will be updated on new commits. |
||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||
| tau_base = std::min(_hsupg[_qp] / (2 * _vel_mag), _dt / 2); | ||
| _taum[_qp] = std::clamp(_taum[_qp], 0.01 * tau_base, 2.0 * tau_base); | ||
| _taue[_qp] = std::clamp(_taue[_qp], 0.01 * tau_base, 2.0 * tau_base); |
There was a problem hiding this comment.
this should likely be added to the explanation of SUPG now
5 participants
Closes #32835
Reason
See issue #32835
Design
See issue #32835
Impact
See issue #32835