Skip to content

Add an MFEM Postprocessor to calculate the flux of an MFEM Vector variable through a boundary#32852

Open
amg56 wants to merge 4 commits intoidaholab:nextfrom
amg56:mfem_boundaryflux_postproc
Open

Add an MFEM Postprocessor to calculate the flux of an MFEM Vector variable through a boundary#32852
amg56 wants to merge 4 commits intoidaholab:nextfrom
amg56:mfem_boundaryflux_postproc

Conversation

@amg56
Copy link
Copy Markdown
Collaborator

@amg56 amg56 commented Apr 28, 2026

Closes #32851

Copy link
Copy Markdown
Member

@nmnobre nmnobre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I'll be on AL from tomorrow, so I might hold off merging this till next week for a more careful look. Will enable Valgrind tests in the meantime. EDIT: glad I did :)

_rt_fec(_var.ParFESpace()->GetMaxElementOrder(), getMesh().Dimension()),
_rt_vector_fespace(const_cast<mfem::ParMesh *>(&getMesh()), &_rt_fec),
_rt_var(&_rt_vector_fespace),
_var_coef(&_var),
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make _var_coef a reference, and then you can drop _var and just retrieve the existing coefficient for that variable:

Suggested change
_var_coef(&_var),
_var_coef(getVectorCoefficient("variable")),

Comment on lines +34 to +38
*getMFEMProblem()
.getProblemData()
.gridfunctions.Get(getParam<VariableName>("variable"))
->ParFESpace()
->GetParMesh()),
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*getMFEMProblem()
.getProblemData()
.gridfunctions.Get(getParam<VariableName>("variable"))
->ParFESpace()
->GetParMesh()),
getMFEMProblem()
.getMFEMVariableMesh(getParam<VariableName>("variable"))),

This'll probably need clang-formatting.


!listing mfem/submeshes/av_magnetostatic.i block=Postprocessors/CoilCurrent


Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@moosebuild
Copy link
Copy Markdown
Contributor

Job Test, step Results summary on d7c9cf7 wanted to post the following:

Framework test summary

Compared against ba7b856 in job civet.inl.gov/job/3782078.

Added tests

Test Time (s) Memory (MB)
mfem/submeshes.MFEMBoundaryFluxCutTransitionSubMesh 18.78 468.42

Modules test summary

Compared against ba7b856 in job civet.inl.gov/job/3782078.

No added tests

Run time changes

Test Base (s) Head (s) +/- Base (MB) Head (MB)
stochastic_tools/test:web_server_control.stochastic_control/normal 2.68 5.20 +94.13% 268.49 277.80

@moosebuild
Copy link
Copy Markdown
Contributor

Job Documentation, step Docs: sync website on d7c9cf7 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Copy Markdown
Contributor

Job Coverage, step Generate coverage on d7c9cf7 wanted to post the following:

Framework coverage

ba7b85 #32852 d7c9cf
Total Total +/- New
Rate 85.87% 85.87% +0.00% 100.00%
Hits 132292 132327 +35 32
Misses 21772 21769 -3 0

Diff coverage report

Full coverage report

Modules coverage

Thermal hydraulics

ba7b85 #32852 d7c9cf
Total Total +/- New
Rate 88.93% 88.93% +0.01% -
Hits 15439 15440 +1 0
Misses 1922 1921 -1 0

Diff coverage report

Full coverage report

Full coverage reports

Reports

This comment will be updated on new commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MFEM Boundary Flux Postprocessor

3 participants