Fix element damper evaluation on undefined variables (#32058)

[BozoVazic]

closes #32058

Reason

Element dampers could still be evaluated on elements where a block-restricted variable to damp is undefined. In that case, element damper data such as solution/increment arrays can be empty, which leads to a MooseArray out-of-bounds access during damping evaluation.

Design

This mirrors the nodal damper fix.

The change adds an element-level guard in ElementDamper to determine whether the damper variable is defined on the current element. ComputeElemDampingThread then:

• only collects variables for dampers whose variable is defined on the current element,
• only reinitializes increment data for those variables, and
• skips computeDamping() for dampers whose variable is undefined there.

A scalar-variable mooseAssert was also added in ElementDamper, analogous to the nodal-side guard.

A regression test was added for the block-restricted elemental bounding-value damper case, and the existing element damper test issue tags were updated so the legacy tests keep #7856 while the new regression test is associated with #32058.

Impact

This does not change the user-facing API. It fixes incorrect element damper evaluation for block-restricted variables and adds regression coverage for that case.

Validation was performed in both execution modes:

• threaded execution reproduced the failure pre-patch and passed post-fix
• pure MPI execution reproduced the failure pre-patch and passed post-fix

[BozoVazic]

@GiudGiud I've added fix for element damper - simillar as for nodal damper

[GiudGiud]

great fix!

test failures. looks like damping is not being applied

[moosebuild]

Job Test, step Results summary on 7154c8d wanted to post the following:

Framework test summary

Compared against 4e53b3b in job civet.inl.gov/job/3786076.

Added tests

Test	Time (s)	Memory (MB)
dampers/bounding_value_element_damper.bounding_value_block_restricted	0.74	60.69

Modules test summary

Compared against 4e53b3b in job civet.inl.gov/job/3786076.

No change

[moosebuild]

Job Documentation, step Docs: sync website on 7154c8d wanted to post the following:

View the site here

This comment will be updated on new commits.