Skip to content

Mattdon/new melcor interface #2017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 56 commits into
base: devel
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 49 commits
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
12d25ce
Update melcorCombinedInterface.py
mattdon Oct 18, 2022
e74717b
Delete MELCORdata.py
mattdon Oct 18, 2022
0fa7df7
Delete melcorInterface.py
mattdon Oct 18, 2022
33bc4ce
Delete melgenInterface.py
mattdon Oct 18, 2022
e0ead47
Update melcorCombinedInterface.py
mattdon Oct 18, 2022
9e98ecb
Update melcorCombinedInterface.py
mattdon Oct 28, 2022
446f280
Merge branch 'idaholab:devel' into New_MELCOR_Interface
mattdon Oct 28, 2022
9f398e0
Update test_melcor_interface.xml
mattdon Nov 2, 2022
49913b9
merge
mattdon Nov 11, 2022
6deb3ab
merge
mattdon Nov 11, 2022
216cb92
Merge branch 'devel' into mattdon/New_MELCOR_Interface
mandd Nov 17, 2022
081f5f6
Revert "merge"
wangcj05 Nov 17, 2022
5b1c43a
first cleaning of PR
mandd Nov 18, 2022
99e71a0
Merge branch 'devel' into mattdon/New_MELCOR_Interface
mandd Dec 15, 2022
8bcc76f
edits
mandd Jan 12, 2023
2c71868
Merge branch 'devel' into mattdon/New_MELCOR_Interface
mandd Jan 12, 2023
508d1a0
Merge remote-tracking branch 'origin/mattdon/New_MELCOR_Interface' in…
mandd Jan 16, 2023
d0b5a91
edit test files
mandd Jan 17, 2023
a569931
edit combinedInterface file
mandd Jan 17, 2023
4954399
added test files
mandd Jan 17, 2023
ad60e3a
missing test file
mandd Jan 17, 2023
9fdb226
fix for diego
Jan 18, 2023
5f2c16c
small edits
mandd Feb 15, 2023
879acc3
Merge remote-tracking branch 'origin/devel' into mattdon/New_MELCOR_I…
mandd Feb 17, 2023
3eb7f67
added edits from rome
mandd Feb 22, 2023
ab83307
edit file
mandd Feb 24, 2023
b065ddb
final files
mandd May 26, 2023
d8c1ae7
removed last file
mandd May 26, 2023
3108b58
Merge branch 'devel' into mattdon/New_MELCOR_Interface
aalfonsi May 27, 2023
e1ec0f5
removed whitespaces
aalfonsi May 27, 2023
65d3231
Update ravenframework/Models/PostProcessors/SubdomainBasicStatistics.py
aalfonsi May 27, 2023
e81ace2
fixed dictionary format
aalfonsi Jun 1, 2023
303b225
fixed dictionary format
aalfonsi Jun 1, 2023
d52231b
updated test
aalfonsi Jun 1, 2023
851e8df
final edits
mandd Jun 2, 2023
a5c4085
addressing comments
mandd Jun 23, 2023
d0d345c
addressing comments
mandd Sep 22, 2023
82b7798
addressing comments
mandd Apr 2, 2025
15e63d3
Merge remote-tracking branch 'origin/devel' into mattdon/New_MELCOR_I…
mandd Apr 2, 2025
502696a
fixed varNode.text.split($,)
mandd Apr 2, 2025
5bfa421
Update doc/user_manual/code_interfaces/melcor.tex
mandd Apr 2, 2025
df665df
more edits
mandd Apr 2, 2025
0f7d2b7
more edits
mandd Apr 2, 2025
90c7fb8
delete whitespaces
mandd Apr 3, 2025
50185b6
addressing new comments
mandd Apr 3, 2025
0614367
addressing new comments
mandd Apr 16, 2025
c517615
delete whitespaces
mandd Apr 17, 2025
de9ceac
merge with devel
mandd Apr 17, 2025
1e8fbe9
restore test file from devel
mandd Apr 21, 2025
eeebb8c
addressing new comments
mandd Apr 23, 2025
ae2ed94
interface test file moved to new folder
mandd Apr 25, 2025
5ff5396
cleaned files
mandd Apr 25, 2025
6a6275c
restore files
mandd Apr 25, 2025
8bd2848
moved worng files..
mandd Apr 25, 2025
201279a
removed old files
mandd Apr 25, 2025
05c2303
add missing file
mandd Apr 25, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions doc/user_manual/code_interfaces/melcor.tex
Original file line number Diff line number Diff line change
Expand Up @@ -109,17 +109,26 @@ \subsubsection{Models}
\end{lstlisting}
As it can be seen above, the \xmlNode{preexec} node must be specified, since MELCOR 2.1/2.2 must run the MELGEN utility
code before executing. Once the \xmlNode{preexec} node is inputted, the execution of MELGEN is performed automatically by the Interface.
Two addtional nodes need to be specified: the first one (i.e., \xmlNode{CodePlotFile}) indicates the name of the MELCOR plot file.
The second one (i.e., \xmlNode{MelcorOutput}) specifies the name of the MELCOR message file.
Comment on lines +112 to +113
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest add more detailed descriptions here. For example, what are the text format for the nodes? I assume the code can only accept one file for each of the nodes.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a small additional description, now that we have a MELCOR user in the group we will gather more experience on this interface

Note that only one file can be specified in each of these two nodes (i.e., \xmlNode{MelcorOutput} and \xmlNode{CodePlotFile}).
\\In addition, if some command line parameters need to be passed to MELCOR, the user might use (optionally) the \xmlNode{clargs} XML nodes.
\\Lastly, the \xmlNode{variables} node should contain a list of comma separated variables generated by MELCOR that should retrieved
by the RAVEN-MELCOR interface.
\begin{lstlisting}[style=XML]
<Models>
<Code name='MyMELCOR' subType='Melcor'>
<executable>~/path_to_the_executable_of_melcor</executable>
<preexec>~/path_to_the_executable_of_melgen</preexec>
<clargs type="text" arg="-r whatever command line instruction"/>
<CodePlotFile>MELPTF.PTF</CodePlotFile>
<MelcorOutput>MELMES_v2-0</MelcorOutput>
<variables>CVH-P_1, CVH-TLIQ_2, CFVALU_2</variables>
</Code>
</Models>
\end{lstlisting}


%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
\subsubsection{Distributions}
The \xmlNode{Distribution} block defines the distributions that are going
Expand Down
1 change: 0 additions & 1 deletion ravenframework/CodeInterfaceClasses/Factory.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
from .MAAP5.MAAP5Interface import MAAP5
from .MAMMOTH.MAMMOTHInterface import MAMMOTH
from .MELCOR.melcorCombinedInterface import Melcor
from .MELCOR.melcorInterface import MelcorApp
from .MooseBasedApp.BisonAndMeshInterface import BisonAndMesh
from .MooseBasedApp.CubitInterface import Cubit
from .MooseBasedApp.CubitMooseInterface import CubitMoose
Expand Down
152 changes: 0 additions & 152 deletions ravenframework/CodeInterfaceClasses/MELCOR/MELCORdata.py

This file was deleted.

Loading