HTPIPE code interface #2460
HTPIPE code interface #2460
Conversation
|
Job Mingw Test on 2aebaa1 : invalidated by @alfoa |
|
Job Mingw Test on 2aebaa1 : invalidated by @alfoa unrelated failure? |
|
Job Test mac on 319458d : invalidated by @joshua-cogliati-inl failed in set python environment with download failure |
|
Job Mingw Test on e9ed810 : invalidated by @alfoa Fetch error |
|
Job Mingw Test on e9ed810 : invalidated by @alfoa |
1 similar comment
|
Job Mingw Test on e9ed810 : invalidated by @alfoa |
|
''' |
|
Job Mingw Test on e9ed810 : invalidated by @alfoa |
1 similar comment
|
Job Mingw Test on e9ed810 : invalidated by @alfoa |
|
@mandd can you review this or can you assign someone else? |
Sorry, internal network issues at INL, we disabled SRAW until they are fixed. |
…od (createNewInput)
…od (createNewInput)
|
Job Mingw Test on a2b4da6 : invalidated by @joshua-cogliati-inl failed in fetch Directory not empty |
|
Job Test qsubs sawtooth on a2b4da6 : invalidated by @alfoa |
|
Job Mingw Test on a2b4da6 : invalidated by @alfoa fetch error |
|
Job Mingw Test on a2b4da6 : invalidated by @joshua-cogliati-inl failed in fetch Directory not empty |
|
Job Test qsubs sawtooth on a2b4da6 : invalidated by @joshua-cogliati-inl FAILED: Diff tests/cluster_tests/test_mpiqsub_long |
|
Moved MAMMOTH tests in dedicated folder. |
|
Job Test qsubs sawtooth on f1e50b1 : invalidated by @joshua-cogliati-inl failed in fetch Directory not empty |
|
@mandd ? |
| table, whose data and variables depend on the calculation type, which is defined in the input file (first raw of the input file): | ||
| \begin{itemize} | ||
| \item \textit{1}: Calculation of the operational limits (e.g. boiling limits, capillarity limits, etc.) | ||
| \item \textit{2}: Calculation of pressure and temperature distribution along the heat pipe |
There was a problem hiding this comment.
so no transient calculations?
There was a problem hiding this comment.
Yeah HTPIPE is a steady state only software
| raise Exception('No correct input file has been found. HTPIPE input must be of type "htpipe". Got: '+' '.join(inputFiles)) | ||
| return inputFile | ||
|
|
||
| def getInputExtension(self): |
There was a problem hiding this comment.
is this methods being used somewhere?
There was a problem hiding this comment.
This is called by the ``ravenframework/Models/Code.py'' class.
Since there is a default ``.i'', I overload the method here because HTPIPE does not use extensions.
| @ In, None | ||
| @ Out, getInputExtension, tuple(str), the ext of the code input file (empty string here) | ||
| """ | ||
| return ("",) |
There was a problem hiding this comment.
what's the scope of this returned object?
There was a problem hiding this comment.
Since there is a default ``.i'', I overload the method here because HTPIPE does not use extensions.
| @ Out, valid, bool, 'True' if an input file has an extension of '.nescene', otherwise 'False'. | ||
| """ | ||
| valid = False | ||
| if inputFile.getType().lower() == 'htpipe': |
There was a problem hiding this comment.
where do we check for the ".nescene" extension (see method descirption in @out)?
There was a problem hiding this comment.
sorry left over. Changed docstring (@ Out, valid, bool, 'True' if an input file has a type == htpipe, otherwise 'False'.)
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Ref. #611
What are the significant changes in functionality due to this change request?
This PR introduces a new code interface in RAVEN to drive calculation using HTPIPE software from Los Alamos (see https://www.osti.gov/servlets/purl/5839045).
The code interface has been developed, tests added and documentation updated.
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>to True.raven/tests/framework/user_guideandraven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.