Updated Sockeye and DireWolf#793
Merged
joshuahansel merged 1 commit intoidaholab:develfrom Apr 23, 2026
Merged
Conversation
|
Job VTB Documentation, step Sync Docs on 7600882 wanted to post the following: View the site here This comment will be updated on new commits. |
Contributor
|
Lets get this in first and I'll update my PR on the submodule updates here: #792. |
joshuahansel
force-pushed
the
update-sockeye
branch
from
5a2602b to
ad44a02
Compare
gambka
approved these changes
Apr 23, 2026
GiudGiud
requested changes
Apr 23, 2026
Collaborator
GiudGiud
left a comment
GiudGiud
left a comment
There was a problem hiding this comment.
DW devel fails an assert in the new code
https://civet.inl.gov/job/3767002/
Some tests needed modification due to condenser pool PP being computed on INITIAL now. Refs #0
joshuahansel
force-pushed
the
update-sockeye
branch
from
ad44a02 to
7600882
Compare
Collaborator
Author
|
Darn, updated input file to avoid this. Meanwhile I'll make the fix in MOOSE to avoid division by zero, but that won't be needed here. |
GiudGiud
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some tests needed modification due to condenser pool PP being computed on INITIAL now.
Refs #0