Skip to content

Conversation

@davidverweij
Copy link
Member

@davidverweij davidverweij commented Mar 25, 2021

pip recently dropped support (see ongoing discourse) for setting constraints on url based dependencies. The nox-poetry resolved this in their package recently (I believe by ignoring url based dependencies in the requirements.txt file export). This PR implements the nox-poetry. Nox-poetry replaces the logic to install with contraints in nox.

Testing

  • Pull nox_fix branch
  • run poetry install
  • run poetry shell
  • run poetry run nox -r
    Everything should pass expect two tests

@davidverweij davidverweij requested a review from jawrainey March 25, 2021 11:34
@davidverweij davidverweij self-assigned this Mar 25, 2021
@davidverweij davidverweij added bug Oh my tests error prevention labels Mar 25, 2021
@jawrainey jawrainey merged commit ff46d52 into master Mar 25, 2021
@jawrainey jawrainey deleted the nox_fix branch March 25, 2021 11:46
@jawrainey
Copy link
Member

Works as expected and solves the issue 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Oh my tests error prevention

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants