Bug fixed

[rkpoddar]

I have made a few appropriate changes in the code. It is no longer creating empty 0 byte files.

[ideamonk]

I understand that changes to spoj urls & in the ways they serve results might've been the root cause. If so, it would've also failed at authentication stage. Anyway,

I wouldn't be merging this straight off because -

1. changes on 10,11, 15,16,17 seem to be based upon an old version of spojbackup.py. Base your changes on latest - https://github.com/ideamonk/spojbackup/blob/master/spojbackup.py
2. changes have conflicting tab sizes

Now, that you have had to alter the url "http://spoj.pl" everywhere, how about putting it out in a global and re-using it as a base url wherever needed? (in that way we could also add support for spoj.br, etc, later, with ease)

Authors and contributors are maintained in README, changes to copyright info, authors are unwelcome.

So, would you be sending a revised pull request?

Thanks!

[rkpoddar]

Sorry for the late reply. At present i am busy with my other projects and
college work. So, i won't be sending a revised pull request anytime soon.

Thanks.

---Rishi Poddar

On Tue, Jan 29, 2013 at 10:42 AM, Abhishek Mishra
[email protected]:

I understand that changes to spoj urls & in the ways they serve results
might've been the root cause. If so, it would've also failed at
authentication stage. Anyway,

I wouldn't be merging this straight off because -

1. changes on 10,11, 15,16,17 seem to be based upon an old version of
   spojbackup.py. Base your changes on latest -
   https://github.com/ideamonk/spojbackup/blob/master/spojbackup.py
2. changes have conflicting tab sizes

Now, that you have had to alter the url "http://spoj.pl" everywhere, how
about putting it out in a global and re-using it as a base url wherever
needed? (in that way we could also add support for spoj.br, etc, later,
with ease)

Authors and contributors are maintained in README, changes to copyright
info, authors are unwelcome.

So, would you be sending a revised pull request?

Thanks!

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-12820849.

[ideamonk]

No probs :)