upgrade core-js to the latest version #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 17, 2021
Closed
Contributor
Author
|
Ping @idiotWu |
Owner
|
Sorry for the delay. Can you update the branch so that it can be merged into dev? |
Contributor
Author
|
Resolved the conflicts |
Owner
|
Shipped as v8.6.0. Thanks! |
|
Hi all, sorry for commenting on a closed PR but this is not a solution. I do not want to load polyfills. A library should never include such, and let the user decide how they want to polyfill. |
Owner
|
@wintercounter I agree with that and I'm going to remove all polyfills in v9 (if I have time). However, as for v8, I think we should still keep the polyfills for consistency. |
|
Thank you for the quick response. |
|
@idiotWu I just noticed this... 4 years ago. I'm going to make a PR that removes core-js for you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi this upgrade the corejs dependency to version 3, previous it was on v2